Skip to content

Conversation

@xvrl
Copy link
Member

@xvrl xvrl commented Feb 28, 2022

  • update maven-surefire-plugin to 3.0.0-M4 for improved compatibility with Java >= 11
    Due to https://issues.apache.org/jira/browse/SUREFIRE-1815 we need to stay on surefire 3.0.0-M4
    until we can upgrade to 3.0.0-M6, since this is causing issues in RetryUtilsTest.
  • upgrade equalsverifier to fix warnings
  • modify EnvironmentVariableDynamicConfigProvider test to not use reflection,
    since those classes are no longer accessible in Java 17
  • add necessary --add-opens flags to pass tests when datasketches-memory is involved
  • fix use of deprecated initMocks method
  • fix mocks not getting closed
  • switch some build steps from Java 15 to Java 17

Note: This doesn't mean we can run with Java 17 yet. While a good portion of the tests pass, we first need to update guice (and by extension guava) in order for dependency injection to work with 17 at runtime.

xvrl added 3 commits February 28, 2022 14:38
Update the following build steps with Java 17 instead of 15:
* packaging
* processing tests
* server tests
@xvrl xvrl marked this pull request as draft March 18, 2022 00:33
@xvrl
Copy link
Member Author

xvrl commented Aug 2, 2022

closing this draft PR, since most of the changes have already been merged as part of #12306 #12395 #12341, and the remaining is addressed by #12839

@xvrl xvrl closed this Aug 2, 2022
@xvrl xvrl deleted the java-17 branch August 2, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants