-
Notifications
You must be signed in to change notification settings - Fork 3.8k
partially run tests with Java 17 #12289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stay on surefire 3.0.0-M4 until we can upgrade to 3.0.0-M6 with a fix for https://issues.apache.org/jira/browse/SUREFIRE-1815 causing issues in RetryUtilsTest.
Update the following build steps with Java 17 instead of 15: * packaging * processing tests * server tests
* remove unneeded strict-java-8 profile
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://issues.apache.org/jira/browse/SUREFIRE-1815 we need to stay on surefire 3.0.0-M4
until we can upgrade to 3.0.0-M6, since this is causing issues in RetryUtilsTest.
since those classes are no longer accessible in Java 17
--add-opensflags to pass tests when datasketches-memory is involvedNote: This doesn't mean we can run with Java 17 yet. While a good portion of the tests pass, we first need to update guice (and by extension guava) in order for dependency injection to work with 17 at runtime.