improve test compatibility with Java 17 and remove deprecated methods #12341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xvrl
commented
Mar 17, 2022
xvrl
commented
- remove use of reflection in EnvironmentVariableDynamicConfigProvider for Java 17 compatibility
- fix mocks mock objects not getting closed properly, causing issues with Java 17
- remove use of deprecated methods and rules in tests
clintropolis
approved these changes
Mar 18, 2022
xvrl
added a commit
that referenced
this pull request
Mar 19, 2022
follow-up to #12341 - fix use of deprecated initMocks methods and properly close mocks on teardown
TSFenwick
pushed a commit
to TSFenwick/druid
that referenced
this pull request
Apr 11, 2022
…apache#12341) * remove use of reflection in EnvironmentVariableDynamicConfigProvider for Java 17 compatibility * fix mocks mock objects not getting closed properly, causing issues with Java 17 * remove use of deprecated methods and rules in tests
TSFenwick
pushed a commit
to TSFenwick/druid
that referenced
this pull request
Apr 11, 2022
follow-up to apache#12341 - fix use of deprecated initMocks methods and properly close mocks on teardown
writer-jill
pushed a commit
to writer-jill/druid
that referenced
this pull request
Jun 22, 2022
…apache#12341) * remove use of reflection in EnvironmentVariableDynamicConfigProvider for Java 17 compatibility * fix mocks mock objects not getting closed properly, causing issues with Java 17 * remove use of deprecated methods and rules in tests
writer-jill
pushed a commit
to writer-jill/druid
that referenced
this pull request
Jun 22, 2022
follow-up to apache#12341 - fix use of deprecated initMocks methods and properly close mocks on teardown
This was referenced Aug 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.