Closed
Conversation
Contributor
|
@cryptoe , I agree that it is weird to contact the ASF served Would it be possible to do this through a mock or through a file uri rather than an http endpoint? |
4640f10 to
893759d
Compare
Contributor
Author
|
Raised a different PR : #12671 |
Contributor
Author
In this case, mocking does not actually test anything hence went ahead with the file based approach. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the unit test
HttpEntitywhich was contactinghttps://druid.apache.org/data/wikipedia.json.gz. Changed it in a way that a local server gets started in the unit test and shuts down when the UT is finished.The uber goal was to fix #10853 but that is tricky as it would require a new Nginx docker image to be bundled to serve static contents.
Will defer it until #12368 makes it into master.
Key changed/added classes in this PR
HttpEntityTestThis PR has: