[Flaky unit test] Adding file based uri.#12671
[Flaky unit test] Adding file based uri.#12671abhishekagarwal87 merged 2 commits intoapache:masterfrom
Conversation
|
The updated test seems to be passing (there is an unrelated failure). But upon taking another look at the method under test, Even though I had suggested using a file uri earlier in #12668 , I guess it is not the best approach to fix this test after all. What do you think @cryptoe? |
|
I am in favor of going via the HTTP route as it's a more robust test. The server approach seemed fine to be as the server is contained in the UT and the cost penalty is not that big. |
|
I agree it'd be better to set up a temporary, in-process HTTP server for this test. |
|
Added the server back. |
Description
Fixes the unit test HttpEntity which was contacting https://druid.apache.org/data/wikipedia.json.gz. Changed it in a way that we are using a local URI.
The uber goal was to fix #10853 but that is tricky as it would require a new Nginx docker image to be bundled to serve static contents.
Will defer it until #12368 makes it into master.
Key changed/added classes in this PR
HttpEntityTestThis PR has: