Web console: fix number of expected functions#13050
Merged
vogievetsky merged 1 commit intoapache:masterfrom Sep 9, 2022
Merged
Web console: fix number of expected functions#13050vogievetsky merged 1 commit intoapache:masterfrom
vogievetsky merged 1 commit intoapache:masterfrom
Conversation
kfaraz
reviewed
Sep 8, 2022
| // Make sure there are enough functions found | ||
| const numFunction = Object.keys(functionDocs).length; | ||
| if (numFunction < MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS) { | ||
| if (!(MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS <= numFunction)) { |
Contributor
There was a problem hiding this comment.
Is this some weird js quirk? How is this different from the original numFunc < MIN_EXPECTED condition?
Contributor
Author
There was a problem hiding this comment.
they behave differently if numFunctions is undefined because all comparisons with undefined are always false:
kfaraz
approved these changes
Sep 9, 2022
vogievetsky
added a commit
to vogievetsky/druid
that referenced
this pull request
Sep 26, 2022
abhishekagarwal87
pushed a commit
that referenced
this pull request
Sep 28, 2022
* fix number of expected functions (#13050) * default to no compare (#13041) * quote columns, datasources in auto complete if needed (#13060) * Web console: better detection for arrays containing objects (#13077) * better detection for arrays containing objects * include boolean also * link to error docs (#13094) * Web console: correctly escape path based flatten specs (#13105) * fix path generation * do escape * fix replace * fix replace for good * append to exisitng callout (#13130) * better spec conversion with issues (#13136) * bump version to 24.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the log message not say
undefined(and rewrite the code so it can not happen again)