Web console: add append to existing callout#13130
Conversation
| onChangeSpec(newSpec: Partial<IngestionSpec>): void; | ||
| } | ||
|
|
||
| export const AppendToExistingIssue = React.memo(function AppendToExistingIssue( |
There was a problem hiding this comment.
Nit: Do we want to call it AppendToExistingIssue?
To me, issue implies that there is a known bug and we are yet to fix it.
There was a problem hiding this comment.
Within the context of the console that is exactly what it is... the user has selected UI options that put the spec in the data loader into a state that can not be submitted. And this callout prompts the user to fix it. Note that I am not making a judgment on whether this behavior is an "issue in Druid" just that the data loader has an internal issue.
The term "issue" is used in the same context all over the console codebase, for example https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L240 - this function will flag an "issue" if spec.dataSchema.dataSource is not set.
There was a problem hiding this comment.
Hmm, I see. Thanks for the clarification 👍🏻
|
I would like to request a change in the suggested CTA to ask them to remove the appendToExisting instead of push people to dynamic partitioning. Dynamic partitioning when mixed with batch ingestion leads to bad clusters more often than not, we should guide people towards things that will leave them in a good state instead. |
* fix number of expected functions (#13050) * default to no compare (#13041) * quote columns, datasources in auto complete if needed (#13060) * Web console: better detection for arrays containing objects (#13077) * better detection for arrays containing objects * include boolean also * link to error docs (#13094) * Web console: correctly escape path based flatten specs (#13105) * fix path generation * do escape * fix replace * fix replace for good * append to exisitng callout (#13130) * better spec conversion with issues (#13136) * bump version to 24.0.1
4 participants
Add an issue callout in the data loader to notify the user that they are in an invalid spec state:
appendToExisting: true+partitionSpec.type != 'dynamic'and give them a CTA on all the relevant screens to help fix it.Full screen: