Skip to content

Correct the properties used at ranger authorizer#13255

Closed
zemin-piao wants to merge 5 commits intoapache:masterfrom
zemin-piao:master
Closed

Correct the properties used at ranger authorizer#13255
zemin-piao wants to merge 5 commits intoapache:masterfrom
zemin-piao:master

Conversation

@zemin-piao
Copy link
Copy Markdown
Contributor

@zemin-piao zemin-piao commented Oct 24, 2022

Description

Following changes are done at druid-ranger-security.md

Correct the default value of use_ugi.

Correct the properties used for ranger authorizer.

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • docs/development/extensions-core/druid-ranger-security.md

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • been tested in a test Druid cluster.

@zemin-piao zemin-piao changed the title Correct the Correct the properties used at ranger authorizer Oct 24, 2022
@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor

@zemin-piao could you please try pulling from the latest master to fix the build failures?

@FrankChen021
Copy link
Copy Markdown
Member

This change reflects current code.

String nameProperty = StringUtils.format("druid.auth.authorizer.%s.name", authorizerName);

And the original doc was introduced in #9579 which has not been changed since then, @bolkedebruin Could you make a confirmation on this change?

Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from docs perspective LGTM. Recommend additional +1 for technical side @FrankChen021 or @bolkedebruin

Thanks for contributing the updates @zemin-piao

Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread helm/druid/Chart.yaml
# limitations under the License.

apiVersion: v2
appVersion: 0.23.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert these yaml files? I can merge the PR afterwards.

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jan 11, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2024

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Feb 9, 2024
zemin-piao pushed a commit to zemin-piao/druid that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants