Druid automated quickstart: zookeeper in service list#13550
Merged
vogievetsky merged 4 commits intoapache:masterfrom Dec 12, 2022
Merged
Druid automated quickstart: zookeeper in service list#13550vogievetsky merged 4 commits intoapache:masterfrom
vogievetsky merged 4 commits intoapache:masterfrom
Conversation
added 2 commits
December 12, 2022 11:33
kfaraz
reviewed
Dec 12, 2022
| -c=conf/druid/single-server/custom \\ | ||
| --zk | ||
| Starts broker, router and zookeeper. | ||
| broker and router config is read from given root directory. |
Contributor
There was a problem hiding this comment.
Suggested change
| broker and router config is read from given root directory. | |
| Configs for broker and router are read from the specified root directory. |
kfaraz
reviewed
Dec 12, 2022
| '{broker, router, middleManager, historical, coordinator-overlord, indexer}. \n' | ||
| '{broker, router, middleManager, historical, coordinator-overlord, indexer, zk}. \n' | ||
| 'If the argument is not given, broker, router, middleManager, historical, coordinator-overlord \n' | ||
| 'and zookeeper is started. e.g. -s=broker,historical') |
Contributor
There was a problem hiding this comment.
Nit: the full word was better, I guess
kfaraz
reviewed
Dec 12, 2022
| MIDDLE_MANAGER = "middleManager" | ||
| TASKS = "tasks" | ||
| INDEXER = "indexer" | ||
| ZK = "zk" |
Contributor
There was a problem hiding this comment.
I think it might be better to just use the full name zookeeper since we are not doing an abbreviation for the other services either.
kfaraz
approved these changes
Dec 12, 2022
added 2 commits
December 12, 2022 15:11
findingrish
changed the title
vogievetsky
approved these changes
Dec 12, 2022
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Dec 12, 2022
Closed
kfaraz
pushed a commit
that referenced
this pull request
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13543.
Description
This change removes
zkarg and instead allows passingzookeeperin the--sargument for the startup script.e.g.
bin/start-druid -s broker,router,historical,coordinator-overlord,middleManager,zookeeperKey changed/added classes in this PR
start-druid-main.pyThis PR has: