Skip to content

Zk should be default#13556

Closed
vogievetsky wants to merge 2 commits intoapache:masterfrom
vogievetsky:zk_should_be_default
Closed

Zk should be default#13556
vogievetsky wants to merge 2 commits intoapache:masterfrom
vogievetsky:zk_should_be_default

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

Fixing a bug introduced in #13550 where the change makes it that there is no ZK by default.

@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Dec 13, 2022

Don't these lines already handle this? (zk = True)

if len(service_list) == 0:
# start all services
service_list = DEFAULT_SERVICES
zk = True

@kfaraz kfaraz added this to the 25.0 milestone Dec 13, 2022
HISTORICAL,
MIDDLE_MANAGER
MIDDLE_MANAGER,
ZK
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZK is not needed in here.
It is passed around as a flag internally.

@kfaraz kfaraz removed this from the 25.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants