Skip to content

Zk should be default #13556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vogievetsky wants to merge 2 commits into from
Closed

Zk should be default #13556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6529a5
add ZK into default list
vogievetsky Dec 12, 2022
8cff0d5
message
vogievetsky Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/bin/start-druid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,7 @@ then
exec python "$WHEREAMI/start-druid-main.py" "$@"
else
echo "python interepreter not found"
echo ""
echo "For more information on installing Python visit:"
echo "https://druid.apache.org/docs/latest/operations/python.html"
fi
3 changes: 2 additions & 1 deletion examples/bin/start-druid-main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
ROUTER,
COORDINATOR,
HISTORICAL,
MIDDLE_MANAGER
MIDDLE_MANAGER,
ZK
Copy link
Copy Markdown
Contributor

@findingrish findingrish Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZK is not needed in here.
It is passed around as a flag internally.

]

SUPPORTED_SERVICES = [
Expand Down