Skip to content

[Backport] [MSQ] Multiple fixes for the MSQ stats merging piece which (#13463)#13567

Merged
cryptoe merged 1 commit intoapache:25.0.0from
cryptoe:msq_sketch_merge_backport
Dec 15, 2022
Merged

[Backport] [MSQ] Multiple fixes for the MSQ stats merging piece which (#13463)#13567
cryptoe merged 1 commit intoapache:25.0.0from
cryptoe:msq_sketch_merge_backport

Conversation

@cryptoe
Copy link
Copy Markdown
Contributor

@cryptoe cryptoe commented Dec 15, 2022

Backports #13463

Stats merging piece bug fixes.

Co-authored-by: cryptoe karankumar1100@gmail.com
(cherry picked from commit 2b605aa)

* Add validation checks to worker chat handler apis

* Merge things and polishing the error messages.

* Minor error message change

* Fixing race and adding some tests

* Fixing controller fetching stats from wrong workers.
Fixing race
Changing default mode to Parallel
Adding logging.
Fixing exceptions not propagated properly.

* Changing to kernel worker count

* Added a better logic to figure out assigned worker for a stage.

* Nits

* Moving to existing kernel methods

* Adding more coverage

Co-authored-by: cryptoe <karankumar1100@gmail.com>
(cherry picked from commit 2b605aa)
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfaraz kfaraz added this to the 25.0 milestone Dec 15, 2022
@cryptoe cryptoe merged commit 9f237c4 into apache:25.0.0 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants