Skip to content

Add basic security functions to druidapi (follow up to #14009)#14055

Merged
vtlim merged 14 commits intoapache:masterfrom
abhishekrb19:pr_14009_security_fixes
Apr 11, 2023
Merged

Add basic security functions to druidapi (follow up to #14009)#14055
vtlim merged 14 commits intoapache:masterfrom
abhishekrb19:pr_14009_security_fixes

Conversation

@abhishekrb19
Copy link
Copy Markdown
Contributor

Pull in @paul-rogers's changes from #14009. This PR addresses the review feedback from the PR and applies some more additional changes, including:

  • Add ```bash and remove $> from codeblocks so they can be copy-pasted as-is or run from an IDE.
  • Fix a typo

This PR has:

Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread docs/operations/security-overview.md Outdated
Comment thread examples/quickstart/jupyter-notebooks/druidapi/druidapi/basic_auth.py Outdated
abhishekrb19 and others added 8 commits April 10, 2023 16:55
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…auth.py

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Copy link
Copy Markdown
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtlim vtlim merged commit 5ce1b09 into apache:master Apr 11, 2023
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants