Skip to content

Document storeCompactionState#14354

Merged
techdocsmith merged 5 commits intoapache:masterfrom
ektravel:docs-context-param
Jun 2, 2023
Merged

Document storeCompactionState#14354
techdocsmith merged 5 commits intoapache:masterfrom
ektravel:docs-context-param

Conversation

@ektravel
Copy link
Copy Markdown
Contributor

@ektravel ektravel commented May 30, 2023

Document storeCompactionState context parameter

This PR:

  • Rearranges the context parameters in alphabetical order.
  • Add storeCompactionState context parameter to the table.
  • Add "ingestion/tasks" back to sidebars.json (mistakenly removed on PR 14023)

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@ektravel
Copy link
Copy Markdown
Contributor Author

ektravel commented May 30, 2023

@suneet-s Please review the definition for storeCompactionState on line 394.

kfaraz
kfaraz reviewed May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, @ektravel . I have left some comments.

Comment thread docs/ingestion/tasks.md Outdated
Comment thread docs/ingestion/tasks.md Outdated
suneet-s
suneet-s reviewed Jun 1, 2023
View reviewed changes
Comment thread docs/ingestion/tasks.md Outdated
techdocsmith
techdocsmith approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit 7fd215b into apache:master Jun 2, 2023
@ektravel ektravel deleted the docs-context-param branch June 2, 2023 18:13
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@techdocsmith techdocsmith techdocsmith approved these changes

@suneet-s suneet-s suneet-s approved these changes

@kfaraz kfaraz Awaiting requested review from kfaraz

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ektravel @kfaraz @techdocsmith @suneet-s @abhishekagarwal87