Skip to content

Update Ingestion section#14023

Merged
techdocsmith merged 53 commits intoapache:masterfrom
ektravel:docs-nav-update
May 19, 2023
Merged

Update Ingestion section#14023
techdocsmith merged 53 commits intoapache:masterfrom
ektravel:docs-nav-update

Conversation

@ektravel
Copy link
Copy Markdown
Contributor

@ektravel ektravel commented Apr 4, 2023

Preview

https://spectacular-dieffenbachia-f33981.netlify.app/docs/ingestion/index.html

Description

The purpose of this PR is to rearrange the Ingestion section to promote MSQ/SQL as the primary batch ingestion option.

This PR:

  • Moves SQL-based ingestion subsection to the top
  • Adds "Legacy" to native batch ingestion docs
  • Drops "ingestion" from section titles
  • Adds "Ingestion concepts" subsection
  • Add a new section named API reference
  • Updates the file system so that the files reside in the folder where the content is displayed (some exceptions apply)
  • Relocates the following files:
    docs/{development => configuration}/extensions.md
    docs/{dependencies => design}/deep-storage.md
    docs/{dependencies => design}/metadata-storage.md
    docs/ingestion/{data-model.md => schema-model.md}
    docs/{design => operations}/auth.md
    docs/{development => querying}/geo.md
    docs/{misc => querying}/math-expr.md

This PR has:

  • been self-reviewed.

@ektravel ektravel marked this pull request as ready for review April 4, 2023 19:54
@techdocsmith
Copy link
Copy Markdown
Contributor

@ektravel , can you fix the merge conflicts. Also, I think maybe let's not rename "Native batch" to "Legacy batch" but "JSON based batch" if that is OK. It is more descriptive and I don't think it will be retired very soon.

Comment thread website/i18n/en.json Outdated
Comment thread website/sidebars.json Outdated
Comment thread docs/api-reference/api.md Outdated
Comment thread docs/api-reference/tasks.md
Comment thread docs/tutorials/tutorial-rollup.md Outdated
@ektravel ektravel requested review from techdocsmith and vtlim April 27, 2023 18:00
Copy link
Copy Markdown
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good after the feedback sessions

Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/labeler.yml
Copy link
Copy Markdown
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some unintended changes in this PR that we need to figure out, ie deletions that shouldn't have happened

vtlim and others added 16 commits May 18, 2023 16:28
…src/main/java/org/apache/druid/k8s/overlord/common/K8sTaskId.java
…src/main/java/org/apache/druid/k8s/overlord/common/KubernetesOverlordUtils.java
…src/main/java/org/apache/druid/k8s/overlord/taskadapter/PodTemplateTaskAdapter.java
…src/test/java/org/apache/druid/k8s/overlord/taskadapter/PodTemplateTaskAdapterTest.java
…src/test/java/org/apache/druid/k8s/overlord/common/KubernetesOverlordUtilsTest.java
…src/test/resources/expectedNoopJobLongIds.yaml
Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants