update links in jupyter notebook#14404
Merged
vtlim merged 3 commits intoapache:masterfrom Jul 3, 2023
Merged
Conversation
317brian
requested changes
Jun 12, 2023
Contributor
There was a problem hiding this comment.
the MSQ link is wrong. Docusaurus URLs use the directory/ID for the URL. That info was probably changed since it got moved into a directory with other APIs, so you'll need to find the new one.
Verified the changes by running a local version of the site and changing
from
druid.apache.org/docs/latest/REST_OF_URL
to
localhost:3000/docs/REST_OF_URL
317brian
approved these changes
Jun 21, 2023
Contributor
317brian
left a comment
There was a problem hiding this comment.
LGTM. Tested the MSQ link using http://localhost:3000/docs/api-reference/sql-ingestion-api.html
vtlim
approved these changes
Jul 3, 2023
2b70b70 to
132d14a
Compare
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed links from PR: Update Ingestion section #14023 update.
This PR has: