Skip to content

update links in jupyter notebook#14404

Merged
vtlim merged 3 commits intoapache:masterfrom
demo-kratia:revert-jupyter-links
Jul 3, 2023
Merged

update links in jupyter notebook#14404
vtlim merged 3 commits intoapache:masterfrom
demo-kratia:revert-jupyter-links

Conversation

@demo-kratia
Copy link
Copy Markdown
Contributor

Fixed links from PR: Update Ingestion section #14023 update.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@317brian 317brian Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the MSQ link is wrong. Docusaurus URLs use the directory/ID for the URL. That info was probably changed since it got moved into a directory with other APIs, so you'll need to find the new one.

Verified the changes by running a local version of the site and changing

from

druid.apache.org/docs/latest/REST_OF_URL

to

localhost:3000/docs/REST_OF_URL

eg http://localhost:3000/docs/api-reference/sql-api.html

Copy link
Copy Markdown
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the MSQ link using http://localhost:3000/docs/api-reference/sql-ingestion-api.html

@demo-kratia demo-kratia force-pushed the revert-jupyter-links branch from 2b70b70 to 132d14a Compare July 3, 2023 19:15
@vtlim vtlim merged commit 4ee7b14 into apache:master Jul 3, 2023
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants