deprecate config-magic in favor of json configuration stuff by clintropolis · Pull Request #14695 · apache/druid

clintropolis · 2023-07-29T05:19:35Z

Description

This PR aims to deprecate usage of config-magic (ConfigProvider) in favor of using JsonConfigProvider everywhere. In the process I have made the config paths a bit more sane (one of the reasons to replace ConfigProvider is because of how easily devs can make paths that don't make much structural sense due to the free-form nature of how config paths are defined).

The main users are DruidProcessingConfig and DruidCoordinatorConfig, the former of which has been reworked to be simple jackson annotated objects which are injected with a fallback to support legacy config-magic paths as needed. After these changes are released, we can consider finally deleting config-magic in a future release.

For DruidProcessingConfig, the structure was mostly ok, but I have flattened the broker parallel merge config into just living at druid.processing.merge (i guess we could change this, i don't feel very strongly), and split it into a totally separate config from the rest of DruidProcessingConfig since it is only used by brokers for CachingClusteredClient.

For DruidCoordinatorConfig WIP (i haven't done anything to it yet, but it definitely needs reworked...)

MonitorSchedulerConfig was also using config-magic annotations, but was no longer using ConfigProvider and so seemed unnecessary so I have just flattened it into DruidMonitorSchedulerConfig which has moved to druid-processing, because it was already wired up to JsonConfigProvider.

Release note

Broker parallel merge config options at paths druid.processing.merge.pool.* and druid.processing.merge.task.* have been flattened to use the druid.processing.merge prefix. Note that the legacy paths will still function, but will issue a warning log noting that these configs have been deprecated and will be removed in a future release, along with the new paths which should be used to continue configuring these values.

This PR has:

been self-reviewed.
added documentation for new or modified features or behaviors.
a release note entry in the PR description.
added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
added or updated version, license, or notice information in licenses.yaml
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
added integration tests.
been tested in a test Druid cluster.

…nfig-magic

-    );
-  }
+  @Rule
+  public ExpectedException expectedException = ExpectedException.none();


+    Injector injector = Initialization.makeInjectorWithModules(
+        GuiceInjectors.makeStartupInjector(),
+        ImmutableList.of(
+            Modules.override(
+                (binder) -> {
+                  binder.bindConstant().annotatedWith(Names.named("serviceName")).to("test");
+                  binder.bindConstant().annotatedWith(Names.named("servicePort")).to(0);
+                  binder.bindConstant().annotatedWith(Names.named("tlsServicePort")).to(-1);
+                  binder.bind(Properties.class).toInstance(props);
+                  ConfigurationObjectFactory factory = Config.createFactory(props);
+                  LegacyBrokerParallelMergeConfig legacyConfig = factory.build(LegacyBrokerParallelMergeConfig.class);
+                  binder.bind(ConfigurationObjectFactory.class).toInstance(factory);
+                  binder.bind(LegacyBrokerParallelMergeConfig.class).toInstance(legacyConfig);
+                },
+                target
+            ).with((binder) -> {
              binder.bind(CachePopulatorStats.class).toInstance(cachePopulatorStats);
              binder.bind(CacheConfig.class).toInstance(cacheConfig);
-            }
+            })
        )
-        )));
+    );


kfaraz

@clintropolis , the changes look good to me overall. I have left some minor comments.

As for DruidCoordinatorConfig, I am looking into how we can clean up the structure. I will share my thoughts here soon.

But for now, I think we should merge the current PR (as it has already touched several files) and tackle DruidCoordinatorConfig in a separate PR of its own.

kfaraz · 2023-08-13T04:53:05Z

+                      : numThreads;
+    this.numMergeBuffers = numMergeBuffers == null ? Math.max(2, this.numThreads / 4) : numMergeBuffers;
+    this.fifo = fifo == null || fifo;
+    this.tmpDir = tmpDir == null ? System.getProperty("java.io.tmpdir") : tmpDir;


Nit: You could consider using Configs.valueOrDefault() utility method for better readability.

Suggested change

this.tmpDir = tmpDir == null ? System.getProperty("java.io.tmpdir") : tmpDir;

this.tmpDir = Configs.valueOrDefault(tmpDir, System.getProperty("java.io.tmpdir"));

cool, didn't know that existed, changed to use this where appropriate

kfaraz · 2023-08-13T04:59:23Z

  private Period emissionPeriod = new Period("PT1M");

+  @JsonProperty
  public String getSchedulerClassName()


Nit: Do methods need to be annotated too? Would this object need to be serialized?

they don't currently get serialized so its not really necessary, not sure why some of the getters here had them, removed them all to make consistent

kfaraz · 2023-08-13T05:00:31Z

  }

-  @Override
  public Duration getEmitterPeriod()


Should probably be renamed to getEmissionDuration to avoid confusion with the other method.

renamed, though the other method wasn't actually used which became apparent after removing the json annotation, so i removed it too

kfaraz · 2023-08-13T05:09:20Z

-
-  @Config({"druid.computation.buffer.size", "${base_path}.buffer.sizeBytes"})
-  public HumanReadableBytes intermediateComputeSizeBytesConfigured()
+  public static long computeMaxMemoryFromMaxHeapSize()


This method is probably not needed, we should just in-line it in initializeBufferSize.

kfaraz · 2023-08-13T05:12:58Z


-public class DruidProcessingConfigModule implements Module
+@Deprecated
+public class LegacyBrokerParallelMergeConfigModule implements Module


Please add a comment about why this is still needed and what needs to be done to remove it completely.

added javadoc here and to the associated config

kfaraz · 2023-08-13T05:25:40Z

-    if (config.getNumThreadsConfigured() != ExecutorServiceConfig.DEFAULT_NUM_THREADS) {
-      log.error("numThreads[%d] configured, that is ignored on Router", config.getNumThreadsConfigured());
+    if (config.isNumThreadsConfigured()) {
+      log.error("numThreads[%d] configured, that is ignored on Router", config.getNumThreads());


I wonder if we even need to log this. Definitely doesn't need to be an error.

Suggested change

log.error("numThreads[%d] configured, that is ignored on Router", config.getNumThreads());

log.warn("Ignoring configured value for 'numThreads'[%d] as it is not used by the Router.", config.getNumThreads());

changed to warn, iirc the idea was that these configs have no effect on router so logging about it makes it obvious that a config change didn't actually change anything. I don't really feel strongly either way, though i do see some merit to getting feedback when a config is specified that has no effect, however we aren't doing it very consistently

kfaraz · 2023-08-14T03:18:58Z

+public class DruidProcessingBufferConfig
+{
+  public static final HumanReadableBytes DEFAULT_PROCESSING_BUFFER_SIZE_BYTES = HumanReadableBytes.valueOf(-1);
+  public static final int MAX_DEFAULT_PROCESSING_BUFFER_SIZE_BYTES = 1024 * 1024 * 1024;


Nit:

Suggested change

public static final int MAX_DEFAULT_PROCESSING_BUFFER_SIZE_BYTES = 1024 * 1024 * 1024;

public static final int MAX_PROCESSING_BUFFER_SIZE_BYTES = 1024 * 1024 * 1024;

hmm, it is only a default though, if the user specifies a buffer size we use that instead, so this just specifies the max size we use if the user didn't define the buffer size explicitly and we are on a JVM that supports auto computing the size

iow, i didn't change this for now, but am happy to do so if you feel more strongly about it

No, it is fine. We can leave as it is.

kfaraz · 2023-08-14T07:39:43Z

For DruidCoordinatorConfig, I think the following structure should work:

Existing class `DruidCoordinatorConfig` bound to `druid.coordinator`

startDelay
period
indexingPeriod
metadataStoreManagementPeriod
kill: add new class CoordinatorKillConfigs
- unused: add new class KillUnusedSegmentsConfig
  - period
  - durationToRetain
  - ignoreDurationToRetain
  - maxSegments
- supervisor: add new class MetadataCleanupConfig for this and other cleanups below
  - period
  - durationToRetain
- audit
  - period
  - durationToRetain
- datasource
  - period
  - durationToRetain
- rule
  - period
  - durationToRetain
- compaction
  - period
loadqueuepeon: add new class LoadQueuePeonConfig
- type
- loadTimeout (to replace druid.coordinator.load.timeout)
- http: add new class HttpLoadQueuePeonConfig
  - batchSize
  - repeatDelay
  - hostTimeout

Paths to deprecate

Add new class LegacyKillUnusedSegmentsConfig which has the following deprecated paths

druid.coordinator.kill.period
druid.coordinator.kill.durationToRetain
druid.coordinator.kill.ignoreDurationToRetain
druid.coordinator.kill.maxSegments

Add new class LegacyCoordinatorPeriodConfig which has the following deprecated paths

druid.coordinator.period.indexingPeriod
druid.coordinator.period.metadataStoreManagementPeriod

Paths to remove

druid.coordinator.curator.loadqueuepeon.numCallbackThreads
Curator loading is already deprecated and will be removed before the next release. We can remove this config and hardcode the only usage in CliCoordinator to 2 for the time being.
druid.coordinator.load.timeout
This can be replaced by druid.coordinator.loadqueuepeon.loadTimeout. The older config can just be dropped as I have never seen any cluster configure this value to anything other than the default (15 minutes). Also, I have other changes planned for this area which are going to further refine this config.

@clintropolis , let me know what you think.

clintropolis · 2023-08-16T07:41:48Z

For DruidCoordinatorConfig, I think the following structure should work:
...

That seems pretty reasonable to me, since we are switching to JSON config, and a ton of those configs have a period and
durationToRetain, it feels like there is some common class that should be able to be re-used for most of those configs.

druid.coordinator.curator.loadqueuepeon.numCallbackThreads
Curator loading is already deprecated and will be removed before the next release. We can remove this config and hardcode the only usage in CliCoordinator to 2 for the time being.

If for some reason we don't get this removed prior to the next release, we should probably fix it to be consistent with the http load queue peon config, and make its path be druid.coordinator.loadqueuepeon.curator.numCallbackThreads

Changes --------- - Usages of skife config had been deprecated in #14695 and `LegacyBrokerParallelMergeConfig` is the last config class that still uses it. - Remove `org.skife.config` from pom, licenses, log4j2.xml, etc. - Add validation for deleted property paths in `StartupInjectorBuilder.PropertiesValidator` - Use the replacement flattened configs (which remove the `.task` and `.pool` substring)

Changes --------- - Usages of skife config had been deprecated in apache#14695 and `LegacyBrokerParallelMergeConfig` is the last config class that still uses it. - Remove `org.skife.config` from pom, licenses, log4j2.xml, etc. - Add validation for deleted property paths in `StartupInjectorBuilder.PropertiesValidator` - Use the replacement flattened configs (which remove the `.task` and `.pool` substring)

) * Some debug configs * use postgresql as the default metadata store and set a few debug log * Add s3 extension, update local storage directory, use emoji in website title * Update favicon, easier to find the console tab * Add indexer server, add some basic security config, updated historical and broker to use the common druid root directory * Some policy config * add checks for SegmentMetadataQuery * Add thread.sleep for flaky. * auth config * format, and remove temp folder rules * added NoopPolicyEnforcer and RestrictAllTablesPolicyEnforcer class * Support pushing and streaming task payload for HDFS (#17742) Implement pushTaskPayload/streamTaskPayload as introduced in #14887 for HDFS storage to allow larger mm-less ingestion payloads when using HDFS as the deep storage location. * Remove usages of deprecated API Files.write() (#17761) * Add deprecated com.google.common.io.Files#write to forbiddenApis * Replace deprecated Files.write() * Doc: Fix description typo for sqlserver metadata store (#17771) Mistakenly categories under deep storage instead of metadata store. * Fix binding of segment metadata cache on CliOverlord (#17772) Changes --------- - Bind `SegmentMetadataCache` only once to `HeapMemorySegmentMetadataCache` in `SQLMetadataStorageDruidModule` - Invoke start and stop of the cache from `DruidOverlord` rather than on lifecycle start/stop - Do not override the binding in `CliOverlord` * Docs: Remove semicolon from example (#17759) * Restrict segment metadata kill query till maxInterval from last kill task time (#17770) Changes --------- - Use `maxIntervalToKill` to determine search interval for killing unused segments. - If no segment has been killed for the datasource yet, use durationToRetain * Update the Supervisor endpoint to not restart the Supervisor if the spec was unmodified (#17707) Add an optional query parameter called skipRestartIfUnmodified to the /druid/indexer/v1/supervisor endpoint. Callers can set skipRestartIfUnmodified=true to not restart the supervisor if the spec is unchanged. Example: curl -X POST --header "Content-Type: application/json" -d @supervisor.json localhost:8888/druid/indexer/v1/supervisor?skipRestartIfUnmodified=true * Reduce noisy coordinator logs (#17779) * Emit time lag from Kafka supervisor (#17735) Changes --------- - Emit time lag from Kafka similar to Kinesis as metrics `ingest/kafka/lag/time`, `ingest/kafka/maxLag/time`, `ingest/kafka/avgLag/time` - Add new method in `KafkaSupervisor` to fetch timestamps of latest records in stream to compute time lag - Add new field `emitTimeLagMetrics` in `KafkaSupervisorIOConfig` to toggle emission of new metrics * fix processed row formatting (#17756) * Web console: add suggestions for table status filtering. (#17765) * suggest filter values when known * update snapshots * add more d * fix load rule clamp * better segment timeline init * Remove all usages of skife config (#17776) Changes --------- - Usages of skife config had been deprecated in #14695 and `LegacyBrokerParallelMergeConfig` is the last config class that still uses it. - Remove `org.skife.config` from pom, licenses, log4j2.xml, etc. - Add validation for deleted property paths in `StartupInjectorBuilder.PropertiesValidator` - Use the replacement flattened configs (which remove the `.task` and `.pool` substring) * Add field `taskLimits` to worker select strategies (#16889) Changes --------- - Add field `taskLimits` to the following worker select strategies `equalDistribution`, `equalDistributionWithCategorySpec`, `fillCapacityWithCategorySpec`, `fillCapacity` - Add sub-fields `maxSlotCountByType` and `maxSlotRatioByType` to `taskLimits` - Apply these limits per worker when assigning new tasks --------- Co-authored-by: sviatahorau <mikhail.sviatahorau@deep.bi> Co-authored-by: Benedict Jin <asdf2014@apache.org> Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> * remove NullValueHandlingConfig, NullHandlingModule, NullHandling (#17778) * Docs: Add SQL query example (#17593) * Docs: Add query example * Update after review * Update query * Update docs/api-reference/sql-api.md --------- Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com> * More logging cleanup on Overlord (#17780) * Remove maven.twttr repo from pom (#17797) remove usage of dependency:go-offline from build scripts - as it tries to download excluded artifacts --------- Co-authored-by: Zoltan Haindrich <kirk@rxd.hu> * fix bug (#17791) * Log query stack traces for DEVELOPER and OPERATOR personas. (#17790) Currently, query stack traces are logged only when "debug: true" is set in the query context. This patch additionally logs stack traces targeted at the DEVELOPER or OPERATOR personas, because for these personas, stack traces are useful more often than not. We continue to omit stack traces by default for USER and ADMIN, because these personas are meant to interact with the API, not with code or logs. Skipping stack traces minimizes clutter in the logs. * Set useMaxMemoryEstimates=false for MSQ tasks (#17792) * Web console: fix go to task selecting correct task type (#17788) * fix go to task selecting correct task type * support autocompact also * support scheduled_batch, refactor * one more state and update tests * Enable ComponentSuppliers to run queries using Dart (#17787) Enables Calcite*Test-s and quidem tests to run queries with Dart. needed some minor tweaks: changed to use interfaces at some places renamed DartWorkerClient to DartWorkerClientImpl and made DartWorkerClient an interface reused existing parts of the MSQ test system to run the query * Fix single container config creates failing peon tasks (#17794) * Fix single container config creates failing peon tasks * More obvious array error output * Update `k8s-jobs.md` reference (#17805) Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * Footer Copyright Year Update (#17751) * Update docusaurus.config.js * Update docusaurus.config.js * [Revert] Reduce number of metadata transaction retries (#17808) * Revert "Run JDK 21 workflows with latest JDK. (#17694)" (#17806) * Revert "Run JDK 21 workflows with latest JDK. (#17694)" This reverts commit 31ede5c * Review comments. * Review comments. * Revert "reject publishing actions with a retriable error code if a earlier task is still publishing (#17509)" This reverts commit aca56d6. * Fix unstable tests after #17787 and dart usage in quidem-ut (#17814) * fixes * fix cleanup * Use "mix" shuffle spec for target size with nil clusterBy. (#17810) When a nil clusterBy is used, we have no way of achieving a particular target size, so we need to fall back to a "mix" spec (unsorted single partition). This comes up for queries like "SELECT COUNT(*) FROM FOO LIMIT 1" when results use a target size, such as when we are inserting into another table or when we are writing to durable storage. * Docs: Recommend using runtime property javaOptsArray instead of javaOpts * Add minor checks in jetty utils (#17817) Add minor checks in jetty utils class * CI improvement: Leverage cancelled() instead of always() for CI jobs (#17819) * Make MSQ tests use the same datasets as other similar tests (#17818) MSQ tests had their own way of creating the segments/etc - this have lead to that custom datasets didn't worked with them. This patch alters a few things to make it possible to access CompleteSegment for the active segments - which fixed the issue and also enabled the removal of the extra loading codes. * Add unnest tests to quidem (#17825) This PR adds the sql-native unnest tests to quidem. This set of tests has 6392 queries in total, with 5247 positive tests and 1145 negative tests. * Web console: show loader on aux queries (#17804) * show loader on aux queries * show supervisors if not on page 0 * refactor * fix bug fetching data when columns are added or removed * update test * Use compaction dynamic config to enable compaction supervisors (#17782) Changes --------- - Remove runtime property object `CompactionSupervisorConfig` - Add fields `useSupervisors` and `engine` to cluster-level compaction dynamic config - Remove unused field `useAutoScaleSlots` * Retry segment publish task actions without holding locks (#17816) #17802 reverted a retry of failed segment publish actions. This patch attempts to address the original issue by retrying the segment publish task actions on the client (i.e. task) side without holding any locks so that other transactions are not blocked. Changes Add retries to TransactionalSegmentPublisher Add field retryable to SegmentPublishResult Remove class DataStoreMetadataUpdateResult and use SegmentPublishResult instead * Add the capability to turboload segments onto historicals (#17775) Add the capability to set Historicals into a turbo loading mode, to focus on loading segments at the cost of query performance. Context -------- Currently, when a new Historical is started, it initially starts out using a bootstrap thread pool. It uses this thread pool to load any existing cached segments and broadcast segments. Once it loads any segments from both these sources, the historical switches to a smaller thread-pool and begins to serve queries. In certain cases, it would be useful to have the historical switch back to this mode, and focus on loading segments, either to continue loading the initial non-bootstrap segments, or to catch up with assigned segments. This PR adds a coordinator dynamic config that allows servers to be configured to use the larger bootstrap threadpool to load segments faster. Changes --------- - Added a new dynamic coordinator configuration, `turboLoadingNodes`. - Ignore `druid.coordinator.loadqueuepeon.http.batchSize` for servers in `turboLoadingNodes` - Add API on historical to return loading capabilities i.e. num loading threads in normal and turbo mode * Fix resource leak for GroupBy query merge buffer when query matched result cache (#17823) * Fix resource leak for GroupBy query merge buffer when match result cache * Fix resource leak for GroupBy query merge buffer when match result cache * Add test * Add test * Add comment * Add test * Add metric and simulation test for turbo loading mode (#17830) Changes --------- - Add field `loadingMode` to `SegmentChangeStatus` - Including loading mode in `DataSegmentChangeResponse` - Include loading mode in the `description` of metrics emitted from `HttpLoadQueuePeon` - Add simulation test to verify loading mode metrics * Update query example (#17811) * String util upgrade for jdk9+ (#17795) * Update StringUtils.replace() after fix in JDK9 * Upgrade optimized string replace algorithm * Update methods by re-using declared StringUtils#replace method * Replace hard-coded UTF-8 encodings with StandardCharsets * Documentation Fix (#17826) * Enable to run quidem tests against multiple configurations; add conditionals; cleanup framework init (#17829) * cleans up `SqlTestFramework` initialization to leave the `OverrideModule` empty - so that tests could more easily take over parts * remove the `QueryComponentSupplier#createEngine` factory method - instead uses a `Class<SqlEngine>` and use the `injector` to initialize it * enables the usage of `!disabled <supplier> <message>` - to mark cases which are not yet supported with a specific configuration for some reason * fixes that `datasets` was not respecting the `rollup` specification of the ingest * enables to use `MultiComponentSupplier` backed tests - these will turn into matrix tests over multiple componentsuppliers - enabling running the same testcase in different scenarios * Fix failing test in DimensionSchemaUtilsTest (#17832) * Improve performance of segment metadata cache on Overlord (#17785) Description ----------- #17653 introduces a cache for segment metadata on the Overlord. This patch is a follow up to that to make the cache more robust, performant and debug-friendly. Changes --------- - Do not cache unused segments This significantly reduces sync time in cases where the cluster has a lot of unused segments. Unused segments are needed only during segment allocation to ensure that a duplicate ID is not allocated. This is a rare DB query which is supported by sufficient indexes and thus need not be cached at the moment. - Update cache directly when segments are marked as unused to avoid race conditions with DB sync. - Fix NPE when using segment metadata cache with concurrent locks. - Atomically update segment IDs and pending segments in a `HeapMemoryDatasourceSegmentCache` using methods `syncSegmentIds()` and `syncPendingSegments()` rather than updating one by one. This ensures that the locks are held for a shorter period and the update made to the cache is atomic. Main updated classes ---------------------- - `IndexerMetadataStorageCoordinator` - `OverlordDataSourcesResource` - `HeapMemorySegmentMetadataCache` - `HeapMemoryDatasourceSegmentCache` Cleaner cache sync -------------------- In every sync, the following steps are performed for each datasource: - Retrieve ALL used segment IDs from metadata store - Atomically update segment IDs in cache and determine list of segment IDs which need to be refreshed. - Fetch payloads of segments that need to be refreshed - Atomically update fetched payloads into the cache - Fetch ALL pending segments - Atomically update pending segments into the cache - Clean up empty intervals from datasource caches * GroupBy: Fix offsets on outer queries. (#17837) Prior to this patch, an offset specified on a groupBy that itself has an inner groupBy would lead to an error like "Cannot push down offsets". This happened because of a violated assumption: the processing logic assumes that offsets have been pushed into limits (so limit pushdown optimizations can safely be used). This patch adjusts processing to incorporate offsets into limits during processing of subqueries. Later on, in post-processing, offsets are applied as written. * Enable build cache for web-console (#17831) * run audit fix (#17836) * Do not block task actions on Overlord if segment metadata cache is syncing (#17824) * Do not use segment metadata cache until leader has synced * Read from cache only when synced, but write even if sync is pending * Fix compilation * Fix checkstyle, test * Revert some extra changes * Add 3 modes of cache usage * Move enum to SegmentMetadataCache * Run tests in all 3 cache modes * Fix docs and IT configs * Fix config binding * Remove forbidden api * Fix typos, docs and enum casing * Fix doc * Add json, array, aggregation function tests to quidem (#17842) This PR adds the sql-native portion of the json, array, and aggregation function tests to quidem. It adds a total of 9965 queries, with 6752 positive tests and 3213 negative tests. * Optionally include Content-Disposition header in statement results API response (#17840) Adds support for an optional filename query parameter to the /druid/v2/sql/statements/{queryId}/results API. When provided, the response will include a header Content-Disposition: attachment; filename="{filename}", which will instruct a web browser to save the response as a file rather than displaying it inline. This save-as-attachment behavior could be achieved by adding a "download" attribute to the results link, but this only works for same-origin URLs (as in the Web Console). If the UI origin is different from the Druid API origin, browsers will ignore the attribute and serve the results inline, which is poor UX for files that are potentially very large. For the sake of consistency, all successful responses in SqlStatementResource.doGetResults may include this header, even if there are no results. Release note Improved: The "Get query results" statements API supports an optional filename query parameter. When provided, the response will instruct web browsers to save the results as a file instead of showing them inline (via the Content-Disposition header). * Web console: download follow up (#17845) * set filename * update download button * added markdown support * add test * better download * fix TSV * better download behaviour and tests * always show download all button * Fix flaky unit tests in SegmentBootstrapperTest and KinesisIndexTaskTest (#17841) Changes: - Fix flakiness in SegmentBootstrapperTest - Make TestSegmentCacheManager thread safe by moving from ArrayList to CopyOnWriteArrayList - Modify assertions to disregard list ordering since order of list modifications is not always deterministic - Fix flaky KinesisIndexTask tests. * Web console: responding to user feedback about the explore view and fixing bugs (#17844) * better debounce * better cumpose filter * hook up preview filters * better stack handling * fix some props * refactor stack to facet * fix hover part 1 * line hover part 2 * start adding moduleWhere * info popover * add filter icon * toggle button * module filter bar * update TestSegmentCacheManager * revert some style changes * validate datasource in CachingClusteredClient as well * fix build failure and update style * changes * add inlineds test * add sanity check on segment * inject policy enforcer * add PolicyEnforcer binding in MSQTestBase * add check in SinkQuerySegmentWalker * more tests in realtime server * revert config change in examples * revert config change in integration test config * more tests in msq * another test for unnest in msq * add support for policy from extension * more test * refactor MSQTaskQueryMakerTest to use an instance of MSQTaskQueryMaker * Add test for JoinDataSource * add policyEnforcer to withPolicies, and validate segment after segment mapping * fix binding and test * add policy module * mock planner toolbox * revert some injection * add test for stream appenderator * update PolicyEnforcer to take ReferenceCountingSegment as param * update to QueryLifecycleTest * update to SqlTestFramework * pass enforcer to BroadcastJoinSegmentMapFnProcessor and add test. PolicyEnforcer should also deal with multiple layer wrapped segments/ * ReferenceCountingSegment is not allowed to wrap with a SegmentReference, and PolicyEnforcer now validates all segments, remove test cases for inline/lookup. * moving ReferenceCountingSegment to another pr * Revert "Merge remote-tracking branch 'cecemei/debug' into policy" This reverts commit 25ffb7c, reversing changes made to 1e6632f. --------- Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Virushade <70288012+GWphua@users.noreply.github.com> Co-authored-by: Eyal Yurman <eyal.yurman@gmail.com> Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> Co-authored-by: Frank Chen <frank.chen021@outlook.com> Co-authored-by: Chetan Patidar <122344823+chetanpatidar26@users.noreply.github.com> Co-authored-by: aho135 <ash023@ucsd.edu> Co-authored-by: Adithya Chakilam <35785271+adithyachakilam@users.noreply.github.com> Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com> Co-authored-by: Misha <mikhailsviatohorof@gmail.com> Co-authored-by: sviatahorau <mikhail.sviatahorau@deep.bi> Co-authored-by: Benedict Jin <asdf2014@apache.org> Co-authored-by: Clint Wylie <cwylie@apache.org> Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com> Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com> Co-authored-by: Zoltan Haindrich <kirk@rxd.hu> Co-authored-by: Gian Merlino <gianmerlino@gmail.com> Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Om Kenge <88768848+omkenge@users.noreply.github.com> Co-authored-by: Karan Kumar <karankumar1100@gmail.com> Co-authored-by: Lars Francke <lars.francke@stackable.tech> Co-authored-by: Adarsh Sanjeev <adarshsanjeev@gmail.com> Co-authored-by: Akshat Jain <akjn11@gmail.com> Co-authored-by: Andy Tsai <61856143+weishiuntsai@users.noreply.github.com> Co-authored-by: Maytas Monsereenusorn <maytasm@apache.org> Co-authored-by: jtuglu-netflix <jtuglu@netflix.com> Co-authored-by: Lucas Capistrant <capistrant@users.noreply.github.com>

clintropolis added Area - Operations WIP labels Jul 29, 2023

clintropolis changed the title ~~json config based processing and broker merge configs to deprecate config-magic~~ deprecate config-magic in favor of json configuration stuff Jul 29, 2023

clintropolis force-pushed the kill-the-magic branch from 6eba8a8 to 253cc2a Compare July 29, 2023 05:24

json config based processing and broker merge configs to deprecate co…

2c1c4fc

…nfig-magic

clintropolis force-pushed the kill-the-magic branch from 253cc2a to 2c1c4fc Compare July 29, 2023 05:27

clintropolis added Refactoring Area - Dependencies labels Jul 29, 2023

github-advanced-security AI found potential problems Jul 29, 2023

View reviewed changes

kfaraz reviewed Aug 14, 2023

View reviewed changes

clintropolis added 2 commits August 15, 2023 23:55

Merge remote-tracking branch 'upstream/master' into kill-the-magic

214d34d

review stuff

c8cf6d1

oops

799c544

kfaraz approved these changes Aug 16, 2023

View reviewed changes

clintropolis added 5 commits August 16, 2023 03:54

tests

f76b07d

fix style

3075192

fixes

fd357bd

better test

868a5c3

maybe this will fix it

0d3eeb8

clintropolis removed the WIP label Aug 16, 2023

clintropolis merged commit 6b14dde into apache:master Aug 17, 2023

clintropolis deleted the kill-the-magic branch August 17, 2023 01:24

kfaraz mentioned this pull request Aug 22, 2023

Simplify DruidCoordinatorConfig and binding of metadata cleanup duties #14891

Merged

10 tasks

clintropolis mentioned this pull request Aug 30, 2023

cleaning DruidProcessingConfig bindings #14927

Merged

LakshSingla added this to the 28.0 milestone Oct 12, 2023

clintropolis added the Release Notes label Oct 26, 2023

LakshSingla mentioned this pull request Nov 4, 2023

[DRAFT] 28.0.0 release notes #15326

Closed

kfaraz mentioned this pull request Jan 17, 2024

Disable ZK-based segment loading, remove usage of skife from DruidCoordinatorConfig #15705

Merged

10 tasks

kfaraz mentioned this pull request Mar 4, 2025

Remove all usages of skife config #17776

Merged

10 tasks

	this.tmpDir = tmpDir == null ? System.getProperty("java.io.tmpdir") : tmpDir;
	this.tmpDir = Configs.valueOrDefault(tmpDir, System.getProperty("java.io.tmpdir"));

	log.error("numThreads[%d] configured, that is ignored on Router", config.getNumThreads());
	log.warn("Ignoring configured value for 'numThreads'[%d] as it is not used by the Router.", config.getNumThreads());

	public static final int MAX_DEFAULT_PROCESSING_BUFFER_SIZE_BYTES = 1024 * 1024 * 1024;
	public static final int MAX_PROCESSING_BUFFER_SIZE_BYTES = 1024 * 1024 * 1024;

Conversation

clintropolis commented Jul 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release note

Uh oh!

Check notice

Check notice

kfaraz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfaraz commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Existing class DruidCoordinatorConfig bound to druid.coordinator

Paths to deprecate

Paths to remove

Uh oh!

clintropolis commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

clintropolis commented Jul 29, 2023 •

edited

Loading

kfaraz commented Aug 14, 2023 •

edited

Loading

Existing class `DruidCoordinatorConfig` bound to `druid.coordinator`