Simplify DruidCoordinatorConfig and binding of metadata cleanup duties#14891
Merged
kfaraz merged 7 commits intoapache:masterfrom Sep 13, 2023
Merged
Simplify DruidCoordinatorConfig and binding of metadata cleanup duties#14891kfaraz merged 7 commits intoapache:masterfrom
kfaraz merged 7 commits intoapache:masterfrom
Conversation
10 tasks
Comment on lines
-252
to
-257
| final ConditionalMultibind<CoordinatorDuty> conditionalIndexingServiceDutyMultibind = ConditionalMultibind.create( | ||
| properties, | ||
| binder, | ||
| CoordinatorDuty.class, | ||
| CoordinatorIndexingServiceDuty.class | ||
| ); |
Member
There was a problem hiding this comment.
does this mean extensions can no longer provide custom coordinator duties? If so this might require a dev list thread to see if anyone is using this functionality.
It does make sense to update the built-in ones to be handled in a more direct manner, but I wonder if there is some way we could leave this stuff in place to retain this functionality as well.
Member
There was a problem hiding this comment.
oops, forgot about CoordinatorCustomDuty, carry on
clintropolis
approved these changes
Sep 12, 2023
Contributor
Author
|
Thanks for the review, @clintropolis !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DruidCoordinatorConfig. This change would help build towards that.Changes
CliCoordinatortoDruidCoordinatorConfig:druid.coordinator.kill.ondruid.coordinator.kill.pendingSegments.ondruid.coordinator.kill.supervisors.ondruid.coordinator.kill.rules.ondruid.coordinator.kill.audit.ondruid.coordinator.kill.datasource.ondruid.coordinator.kill.compaction.onMetadataManagerwhich contains handles to all the different metadata managers for rules, supervisors, segments, etc.CoordinatorConfigManagerto simplify read and update of coordinator configsCoordinatorCompactionConfigandCoordinatorDynamicConfigas these are config classes and persistence logic should not live here.@CoordinatorIndexingServiceDuty,@CoordinatorMetadataStoreManagementDutyRelease Note
IndexingServiceDutiesandMetadataStoreManagementDutiesanymore. These are meant to be core coordinator built-in flows and should not be affected by custom duties.CustomCoordinatorDutywith a custom duty group and period.This PR has: