Fix flaky assertion in MSQ Unit test#15142
Merged
LakshSingla merged 1 commit intoapache:masterfrom Oct 13, 2023
Merged
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
LakshSingla
reviewed
Oct 12, 2023
| selectTester.setExpectedCountersForStageWorkerChannel( | ||
| CounterSnapshotMatcher | ||
| .with().rows(2, 0, 2).frames(1, 0, 1), | ||
| .with().rows(2, 0, 2), |
Contributor
There was a problem hiding this comment.
Let's not remove the number of frames assertion for the UTs to pass, since that shouldn't be flaky.
If they produce different results with sql-compat and sql-incompat mode, we should have separate assertions based on the mode it is run.
Contributor
Author
There was a problem hiding this comment.
The issue is with how frameProccessors are getting scheduled and not the SQL compat mode.
Since all other PR's are failing, ie a dev blocker, lets merge it till I find a better way to solve it?
LakshSingla
approved these changes
Oct 13, 2023
LakshSingla
changed the title
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Oct 14, 2023
cryptoe
added a commit
that referenced
this pull request
Oct 14, 2023
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the flaky test which was added as part of #14994