Skip to content

Fix flaky assertion in MSQ Unit test #15142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LakshSingla merged 1 commit into from
Oct 13, 2023
Merged

Fix flaky assertion in MSQ Unit test #15142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,22 +1467,21 @@ public void testExternSelectWithMultipleWorkers() throws IOException
);
// adding result stage counter checks
if (isPageSizeLimited()) {
selectTester = selectTester.setExpectedCountersForStageWorkerChannel(
selectTester.setExpectedCountersForStageWorkerChannel(
CounterSnapshotMatcher
.with().rows(2, 0, 2).frames(1, 0, 1),
.with().rows(2, 0, 2),
Copy link
Copy Markdown
Contributor

@LakshSingla LakshSingla Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not remove the number of frames assertion for the UTs to pass, since that shouldn't be flaky.

If they produce different results with sql-compat and sql-incompat mode, we should have separate assertions based on the mode it is run.

Copy link
Copy Markdown
Contributor Author

@cryptoe cryptoe Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is with how frameProccessors are getting scheduled and not the SQL compat mode.
Since all other PR's are failing, ie a dev blocker, lets merge it till I find a better way to solve it?

Copy link
Copy Markdown
Contributor

@LakshSingla LakshSingla Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

1, 0, "input0"
).setExpectedCountersForStageWorkerChannel(
CounterSnapshotMatcher
.with().rows(2, 0, 2).frames(1, 0, 1),
.with().rows(2, 0, 2),
1, 0, "output"
);
selectTester = selectTester.setExpectedCountersForStageWorkerChannel(
).setExpectedCountersForStageWorkerChannel(
CounterSnapshotMatcher
.with().rows(0, 2, 0, 4).frames(0, 1, 0, 1),
.with().rows(0, 2, 0, 4),
1, 1, "input0"
).setExpectedCountersForStageWorkerChannel(
CounterSnapshotMatcher
.with().rows(0, 2, 0, 4).frames(0, 1, 0, 1),
.with().rows(0, 2, 0, 4),
1, 1, "output"
);
}
Expand Down