Add MSQ Durable Storage Connector for Google Cloud Storage and change current Google Cloud Storage client library#15398
Merged
cryptoe merged 30 commits intoapache:masterfrom Dec 14, 2023
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ath call removal in deleteRecursively
| // Continuation token is an index in the "objects" list. | ||
| final String continuationToken = getPageToken(); | ||
| final int startIndex = continuationToken == null ? 0 : Integer.parseInt(continuationToken); | ||
| final int startIndex = pageToken == null ? 0 : Integer.parseInt(pageToken); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
gargvishesh
changed the title
gargvishesh
changed the title
cryptoe
reviewed
Nov 29, 2023
Contributor
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
Changes overall LGTM. Minor comments.
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.apis</groupId> |
Contributor
There was a problem hiding this comment.
We might want to update :
druid/integration-tests-ex/cases/pom.xml
Lines 154 to 164 in 8812495
| // list with prefix can return directories, but they should always end with `/`, ignore them. | ||
| // also skips empty objects. | ||
| if (!next.getName().endsWith("/") && next.getSize().signum() > 0) { | ||
| if (!next.getName().endsWith("/") && Long.signum(next.getSize()) > 0) { |
Contributor
There was a problem hiding this comment.
Nit: Why would size be negative ever ?
Contributor
Author
There was a problem hiding this comment.
This is more a check meant for != 0
| import java.io.OutputStream; | ||
| import java.util.Iterator; | ||
|
|
||
| public class GoogleStorageConnector extends ChunkingStorageConnector<GoogleInputRange> |
Contributor
There was a problem hiding this comment.
I donot see test cases for this class.
Contributor
Author
There was a problem hiding this comment.
Added for this and some other classes as well.
cryptoe
approved these changes
Dec 12, 2023
Contributor
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
Changes LGTM.
Will merge post a green build.
| && Objects.equals(bucket, that.bucket) | ||
| && Objects.equals(path, that.path); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
nit: Lets add a toString to this as well.
Contributor
|
Thanks @gargvishesh for working on this. |
10 tasks
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR addresses 2 things: