Change last update timestamp granularity of GCS objects from seconds to milliseconds#16083
Conversation
|
@gargvishesh , thanks for the fix. |
|
|
||
| } | ||
| @Test | ||
| public void testGetMetadataMismatch() throws IOException |
There was a problem hiding this comment.
what is this test for?
There was a problem hiding this comment.
Oh, I think it is the same as the above test testGetMetadataMismatch() except that it verifies that the timestamp is not in seconds .
@gargvishesh , I think the previous test testGetMetadata() is enough.
|
|
||
| } | ||
| @Test | ||
| public void testGetMetadataMismatch() throws IOException |
There was a problem hiding this comment.
Oh, I think it is the same as the above test testGetMetadataMismatch() except that it verifies that the timestamp is not in seconds .
@gargvishesh , I think the previous test testGetMetadata() is enough.
|
Caused because of : #15398 |
4 participants
The previously used GCS API client library returned last update time for objects directly in milliseconds. The new library returns it in
OffsetDateTimeformat which was being converted to seconds and stored against the object. This fix converts the time back to ms before storing it.