Skip to content

Remove the unused MSQ Controller context reference for Worker task#16285

Merged
kfaraz merged 1 commit intoapache:masterfrom
YongGang:controller-context
Apr 16, 2024
Merged

Remove the unused MSQ Controller context reference for Worker task#16285
kfaraz merged 1 commit intoapache:masterfrom
YongGang:controller-context

Conversation

@YongGang
Copy link
Copy Markdown
Contributor

Description

The MSQ Controller context reference field for Worker task was added in this recent PR #16041
After further discussion, this field should be removed for now.


Key changed/added classes in this PR
  • ControllerImpl.java remove the new controllerCtx reference field for Worker task

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Apr 15, 2024
@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Apr 16, 2024

Relevant comments:
#16041 (comment)
#16041 (comment)

@kfaraz kfaraz merged commit 6964297 into apache:master Apr 16, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants