Skip to content

Remove the unused MSQ Controller context reference for Worker task #16285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfaraz merged 1 commit into from
Apr 16, 2024
Merged

Remove the unused MSQ Controller context reference for Worker task #16285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...nsions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,9 +718,7 @@ private QueryDefinition initializeQueryDefAndState(final Closer closer)
MSQControllerTask.isReplaceInputDataSourceTask(task)
);

// propagate the controller's context and tags to the worker task
taskContextOverridesBuilder.put(MultiStageQueryContext.CTX_OF_CONTROLLER, task.getContext());
// specifically assign the 'tags' field for enhanced worker task metrics reporting
// propagate the controller's tags to the worker task for enhanced metrics reporting
Map<String, Object> tags = task.getContextValue(DruidMetrics.TAGS);
if (tags != null) {
taskContextOverridesBuilder.put(DruidMetrics.TAGS, tags);
Expand Down
7 changes: 0 additions & 7 deletions ...ore/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,6 @@ public class MultiStageQueryContext

public static final String CTX_IS_REINDEX = "isReindex";

/**
* Key for controller task's context passed to worker tasks.
* Facilitates sharing the controller's execution environment
* and configurations with its associated worker tasks.
*/
public static final String CTX_OF_CONTROLLER = "controllerCtx";

/**
* Controls sort order within segments. Normally, this is the same as the overall order of the query (from the
* CLUSTERED BY clause) but it can be overridden.
Expand Down