Web console: Fix the supervisor offset reset dialog.#16298
Merged
vogievetsky merged 9 commits intoapache:masterfrom Apr 20, 2024
Merged
Web console: Fix the supervisor offset reset dialog.#16298vogievetsky merged 9 commits intoapache:masterfrom
vogievetsky merged 9 commits intoapache:masterfrom
Conversation
ektravel
reviewed
Apr 16, 2024
ektravel
reviewed
Apr 16, 2024
ektravel
reviewed
Apr 16, 2024
ektravel
reviewed
Apr 16, 2024
Contributor
ektravel
left a comment
ektravel
left a comment
There was a problem hiding this comment.
Left a few suggestions.
abhishekrb19
approved these changes
Apr 18, 2024
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
ektravel
reviewed
Apr 19, 2024
| </p> | ||
| <p> | ||
| You can configure the exact offsets that the supervisor will read from using | ||
| the Actions menu on the Supervisors tab. the action menu on the Supervisor tab |
Contributor
There was a problem hiding this comment.
Suggested change
| the Actions menu on the Supervisors tab. the action menu on the Supervisor tab | |
| the Actions menu on the Supervisors tab. |
ektravel
reviewed
Apr 19, 2024
| <p> | ||
| You can configure the exact offsets that the supervisor will read from using | ||
| the Actions menu on the Supervisors tab. the action menu on the Supervisor tab | ||
| after submitting a supervisor in a suspended state. |
Contributor
There was a problem hiding this comment.
Suggested change
| after submitting a supervisor in a suspended state. |
ektravel
reviewed
Apr 19, 2024
| <p> | ||
| Creating a supervisor in a suspended state can be helpful if you are not yet | ||
| ready to begin ingesting data or if you prefer to configure the supervisor's | ||
| metadata before submitting it. inserting data yet or if you want to precisely |
Contributor
There was a problem hiding this comment.
Suggested change
| metadata before submitting it. inserting data yet or if you want to precisely | |
| metadata before submitting it. |
ektravel
reviewed
Apr 19, 2024
| Creating a supervisor in a suspended state can be helpful if you are not yet | ||
| ready to begin ingesting data or if you prefer to configure the supervisor's | ||
| metadata before submitting it. inserting data yet or if you want to precisely | ||
| configure the metadata for the supervisor before starting it. |
Contributor
There was a problem hiding this comment.
Suggested change
| configure the metadata for the supervisor before starting it. |
ektravel
reviewed
Apr 19, 2024
Contributor
ektravel
left a comment
ektravel
left a comment
There was a problem hiding this comment.
@vogievetsky The original text didn't get removed after you committed my suggestions.
Contributor
Author
|
Ok got it! |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the dialog implemented here #14863
Basically the old dialog relied on
latestOffsetsto be set to work. This version does not. In addition it provides a fallback JSON view so it is easy to paste in the metadata.Also allows starting a supervisor in a suspended state