Remove logic to disable "hard rest" and "set offsets" button when supervisor is in suspended state#17934
Merged
vogievetsky merged 1 commit intoapache:masterfrom Apr 22, 2025
Merged
Conversation
…ervisor is in suspended state * There is no restriction to suspend the supervisor to reset the offsets at backend apis. * This validation forces the user to suspend which increases the consumer lag further. * Removed the conditions from UI.
Contributor
|
It looks like these conditions were added in #16298. I am not sure if there was a UI reason for it, or if there would be other considerations in removing the conditions. But yes, I believe you're right, from the backend perspective, there isn't a requirement that the supervisor be suspended before resetting it. @vogievetsky - any thoughts on the UI change? |
Contributor
|
There is no specific reason for this restriction other than a safety check to prevent the user from doing a destructive operation. It seems that there exist use cases when resetting running supervisors is expected. I am fine with merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17933.
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: