Skip to content

Remove logic to disable "hard rest" and "set offsets" button when supervisor is in suspended state#17934

Merged
vogievetsky merged 1 commit intoapache:masterfrom
suraj-goel:patch-1
Apr 22, 2025
Merged

Remove logic to disable "hard rest" and "set offsets" button when supervisor is in suspended state#17934
vogievetsky merged 1 commit intoapache:masterfrom
suraj-goel:patch-1

Conversation

@suraj-goel
Copy link
Copy Markdown
Contributor

@suraj-goel suraj-goel commented Apr 17, 2025

  • There is no restriction to suspend the supervisor to reset the offsets at backend apis.
  • This validation forces the user to suspend which increases the consumer lag further.
  • Removed the conditions from UI.

Fixes #17933.

Description

  • Removed disabled conditions for "hard reset" and "set offsets" button when supervisor is suspended.
  • Tested in production druid cluster.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…ervisor is in suspended state

* There is no restriction to suspend the supervisor to reset the offsets at backend apis.
* This validation forces the user to suspend which increases the consumer lag further.
* Removed the conditions from UI.
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Apr 22, 2025

It looks like these conditions were added in #16298. I am not sure if there was a UI reason for it, or if there would be other considerations in removing the conditions. But yes, I believe you're right, from the backend perspective, there isn't a requirement that the supervisor be suspended before resetting it. @vogievetsky - any thoughts on the UI change?

@vogievetsky
Copy link
Copy Markdown
Contributor

There is no specific reason for this restriction other than a safety check to prevent the user from doing a destructive operation. It seems that there exist use cases when resetting running supervisors is expected. I am fine with merging this.

@vogievetsky vogievetsky merged commit 5b123de into apache:master Apr 22, 2025
10 checks passed
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard Reset restricted when supervisor is suspended

4 participants