Skip to content

fixup-16284: Remove the LagMetric class#16314

Merged
kfaraz merged 3 commits intoapache:masterfrom
ac9817:fixup-16284
Apr 20, 2024
Merged

fixup-16284: Remove the LagMetric class#16314
kfaraz merged 3 commits intoapache:masterfrom
ac9817:fixup-16284

Conversation

@ac9817
Copy link
Copy Markdown
Contributor

@ac9817 ac9817 commented Apr 19, 2024

Tries to address the comments made on #16284 after merged.

Key changed/added classes in this PR
  • LagBasedAutoScaler
  • Supervisor
  • Lagmetric

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

kfaraz
kfaraz requested changes Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the title suggests, this PR should also be deleting the LagMetric and LagMetricTest classes.

Comment thread .../java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java Outdated
kfaraz
kfaraz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @adithyachakilam !

github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 19, 2024
View reviewed changes
Comment thread .../java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java
lagMetricsQueue.offer(lag > 0 ? lag : 0L);
}
long lag = supervisor.computeLagForAutoScaler();
lagMetricsQueue.offer(lag > 0 ? lag : 0L);

Check notice

Code scanning / CodeQL

Ignored error status of call

Method run ignores exceptional return value of CircularFifoQueue<Long>.offer.
@kfaraz kfaraz merged commit cff5d1e into apache:master Apr 20, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfaraz kfaraz kfaraz approved these changes

Assignees

No one assigned

Labels

Area - Ingestion Area - Streaming Ingestion

Projects

None yet

Milestone

30.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ac9817 @kfaraz @github-advanced-security @adarshsanjeev