Consider max lag for kinesis while autoscaling#16284
Merged
AmatyaAvadhanula merged 3 commits intoapache:masterfrom Apr 17, 2024
Merged
Consider max lag for kinesis while autoscaling#16284AmatyaAvadhanula merged 3 commits intoapache:masterfrom
AmatyaAvadhanula merged 3 commits intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| long totalLags = lagStats.getTotalLag(); | ||
| lagMetricsQueue.offer(totalLags > 0 ? totalLags : 0L); | ||
| long lag = lagStats.get(supervisor.getLagMetricForAutoScaler()); | ||
| lagMetricsQueue.offer(lag > 0 ? lag : 0L); |
Check notice
Code scanning / CodeQL
Ignored error status of call
added 2 commits
April 15, 2024 22:40
AmatyaAvadhanula
approved these changes
Apr 17, 2024
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
Changes LGTM. Thank you @adithyachakilam
kfaraz
reviewed
Apr 18, 2024
10 tasks
kfaraz
pushed a commit
that referenced
this pull request
Apr 20, 2024
Tries to address the comments made on #16284 after merged. Changes: - Remove method `Supervisor.getLagMetric()` - Add method `Supervisor.computeLagForAutoScaler()` - Remove classes `LagMetric` and `LagMetricTest`
ac9817
pushed a commit
to ac9817/druid
that referenced
this pull request
Apr 25, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In kinesis, lag is computed in minutes rather than count of records as done in kafka. If each shard has a lag of 1 min and there are 10 shards, we were computing that there was 10 mins of lag for auto scaling decisions, but we should be only looking at the max and make the auto scaling decisions. On the other hand, for kafka, the lag considered for autoscaling is total as previously.
Release note
For kinesis streams, autoscaling is now done on max lag per shard rather than the total lag for all shards.
Key changed/added classes in this PR
LagStats.javaLagMetric.javaLabBasedAutoScaler.javaSupervisor.javaThis PR has: