Make #16284 backward compatible#16334
Merged
kfaraz merged 6 commits intoapache:masterfrom Apr 29, 2024
Merged
Conversation
suneet-s
reviewed
Apr 25, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| long lag = lagBasedAutoScalerConfig.getLagStatsType() != null ? | ||
| lagStats.getMetric(lagBasedAutoScalerConfig.getLagStatsType()) : | ||
| lagStats.getPrefferedScalingMetric(); | ||
| lagMetricsQueue.offer(lag > 0 ? lag : 0L); |
Check notice
Code scanning / CodeQL
Ignored error status of call
| lagStats.getPrefferedScalingMetric(); | ||
| lagMetricsQueue.offer(lag > 0 ? lag : 0L); | ||
| } else { | ||
| lagMetricsQueue.offer(0L); |
Check notice
Code scanning / CodeQL
Ignored error status of call
kfaraz
reviewed
Apr 27, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
@adithyachakilam , thanks for the changes! The implementation makes sense. I have just left some suggestions for field names and code structure.
ac9817
force-pushed
the
make-16284-backward-compatible
branch
from
0aa2f9c to
11aea27
Compare
ac9817
force-pushed
the
make-16284-backward-compatible
branch
from
11aea27 to
e80e413
Compare
kfaraz
reviewed
Apr 28, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Final comments, will approve once these are addressed.
kfaraz
reviewed
Apr 28, 2024
kfaraz
approved these changes
Apr 29, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments, @adithyachakilam .
Contributor
|
Merging this PR as the pending tests are stuck due to the issue described in #16347 . The same tests have already passed on a different JDK. |
Contributor
|
@adithyachakilam Can you please backport this change to the 30.0 branch as it looks like #16284 is in that branch |
ac9817
added a commit
to ac9817/druid
that referenced
this pull request
May 2, 2024
Changes: - Add new config `lagAggregate` to `LagBasedAutoScalerConfig` - Add field `aggregateForScaling` to `LagStats` - Use the new field/config to determine which aggregate to use to compute lag - Remove method `Supervisor.computeLagForAutoScaler()`
kfaraz
pushed a commit
that referenced
this pull request
May 3, 2024
Changes: - Add new config `lagAggregate` to `LagBasedAutoScalerConfig` - Add field `aggregateForScaling` to `LagStats` - Use the new field/config to determine which aggregate to use to compute lag - Remove method `Supervisor.computeLagForAutoScaler()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #16284, we changed the way how kinesis autoscaler computes the lag for the purposes of autoscaling. Put that feature behind a flag so as to not annoy customers who have already configured the auto scaler thesholds based on the total lag.
This PR has: