Use correct IT group name for the group cds-coordinator-metadata-query-disabled in GHA#16468
Merged
cryptoe merged 8 commits intoapache:masterfrom May 21, 2024
Merged
Conversation
added 7 commits
March 14, 2024 16:49
findingrish
changed the title
cds-coordinator-metadata-query-enabled in GHAcds-coordinator-metadata-query-disabled in GHA
kfaraz
approved these changes
May 17, 2024
Member
|
I wonder why was this merged ; the integration test this pr enables back doesn't finish in under 6 hours.... |
kgyrtkirk
added a commit
that referenced
this pull request
May 22, 2024
fixes the issue with the newly enabled `cds-coordiantor-metadata-query-disabled` [split](#16468) * configures to use `prepopulated-data` environment things to configure `S3` for access * this is needed because these tests use a [dataset which is loaded from s3](https://github.com/apache/druid/blob/master/integration-tests/docker/test-data/cds-coordinator-metadata-query-disabled-sample-data.sql) * also undoes the previous [fix](#16469) of setting the aws region explicitly as this is a more complete solution - and configuring `prepopulated-data` also sets the region; so that's not needed anymore
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
May 29, 2024
fixes the issue with the newly enabled `cds-coordiantor-metadata-query-disabled` [split](apache#16468) * configures to use `prepopulated-data` environment things to configure `S3` for access * this is needed because these tests use a [dataset which is loaded from s3](https://github.com/apache/druid/blob/master/integration-tests/docker/test-data/cds-coordinator-metadata-query-disabled-sample-data.sql) * also undoes the previous [fix](apache#16469) of setting the aws region explicitly as this is a more complete solution - and configuring `prepopulated-data` also sets the region; so that's not needed anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix usage of outdated IT group name
cds-coordinator-smq-disabled