fix cds-coordinator-metadata-query-disabled#16488
Merged
kgyrtkirk merged 4 commits intoapache:masterfrom May 22, 2024
Merged
Conversation
This reverts commit c948201.
Closed
gianm
approved these changes
May 22, 2024
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
It seems like this helps the test, but why? Please write a PR description prior to merging, so it shows up in the commit log.
Member
Author
|
Thank you @gianm and @findingrish for taking a look; |
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
May 29, 2024
fixes the issue with the newly enabled `cds-coordiantor-metadata-query-disabled` [split](apache#16468) * configures to use `prepopulated-data` environment things to configure `S3` for access * this is needed because these tests use a [dataset which is loaded from s3](https://github.com/apache/druid/blob/master/integration-tests/docker/test-data/cds-coordinator-metadata-query-disabled-sample-data.sql) * also undoes the previous [fix](apache#16469) of setting the aws region explicitly as this is a more complete solution - and configuring `prepopulated-data` also sets the region; so that's not needed anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issue with the newly enabled
cds-coordiantor-metadata-query-disabledsplitprepopulated-dataenvironment things to configureS3for accessprepopulated-dataalso sets the region; so that's not needed anymore