Fix flaky test in ParallelMergeCombiningSequenceTest#16907
Fix flaky test in ParallelMergeCombiningSequenceTest#16907kfaraz merged 1 commit intoapache:masterfrom
Conversation
|
this failure seems like it happens when the timeout happens before we get to the part where we are expecting the timeout to happen, so i'm not sure this PR fixes it (i just saw this on one of my PRs after this has been merged). In the stacktrace it shows failing in the part that is priming the sequence to start the timeout countdown, calling yielders.each and yielder.next before the call to yielder.next that expects the timeout exception to happen: I would assume this is due to the test sometimes running a bit slower than expected so the timeout has elapsed by the time we get to the sequence. I think to be effective both the sequence timeout millis and the thread.sleep should match the 5s set here (i think I wasn't expecting setting up the sequence to take 1s+ when I wrote it so i thought it would be safe...) |
FYI, #16624 (review)
This PR has: