fix flaky ParallelMergeCombiningSequenceTest.testTimeoutExceptionDueToStoppedReader when runner is very slow#16932
Merged
gianm merged 2 commits intoapache:masterfrom Aug 22, 2024
Conversation
…oStoppedReader when runner is very slow
georgew5656
approved these changes
Aug 22, 2024
gianm
approved these changes
Aug 22, 2024
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
…oStoppedReader when runner is very slow (apache#16932)
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Sep 5, 2024
…oStoppedReader when runner is very slow (apache#16932)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16907 (comment). I hope this should work because increasing the timeout on the sequence gives a longer period to initialize all of the sequences which have been started by making a yielder in the loop.
The test wants a timeout to happen, but if the timeout happens during this initialization loop then it is before we are expecting the timeout to happen so instead of passing it fails because the timeout is too soon. We retain the sleep because if the initialization happens really fast we do want to wait long enough for the timeout to occur.