Loosen case in FrameFileWriterTest.#16938
Merged
clintropolis merged 1 commit intoapache:masterfrom Aug 21, 2024
Merged
Conversation
The specific error on a truncated file can vary based on how the final frame of the truncated file is written. This patch loosens the check so it passes regardless of how the truncated file is written.
clintropolis
approved these changes
Aug 21, 2024
Member
|
cool, ran into this trying to fix another flaky test, #16932 |
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
The specific error on a truncated file can vary based on how the final frame of the truncated file is written. This patch loosens the check so it passes regardless of how the truncated file is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specific error on a truncated file can vary based on how the final frame of the truncated file is written. This patch loosens the check so it passes regardless of how the truncated file is written.