Refactor WindowOperatorQueryKit to use WindowStage class for representing different window stages#17158
Merged
cryptoe merged 13 commits intoapache:masterfrom Nov 12, 2024
Conversation
…ting different window stages
9 tasks
kgyrtkirk
reviewed
Sep 30, 2024
kgyrtkirk
reviewed
Oct 9, 2024
Contributor
Author
|
@kgyrtkirk Thank you for the review! I was wondering if it makes sense to get #17038 merged first, and then resolve conflicts on this PR, instead of the other way round? Plus this PR is much smaller than the other one, so it would allow us to iterate faster on this after getting the other PR merged. If we try to merge this PR first, a lot of this PR's logic would have to be re-worked when resolving conflicts on the GlueingPartitioningOperator PR. That PR is already huge, it would be unnecessary to re-work this PR's logic there. Thoughts? |
Member
|
we will merge the PR which is ready first I've suggested to open this from that pr here - so I think the natural order is to have this one finished first |
kgyrtkirk
reviewed
Oct 10, 2024
…atorQueryKit-stage-creation
9 tasks
kgyrtkirk
approved these changes
Nov 11, 2024
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
…ting different window stages (apache#17158)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
WindowOperatorQueryKitto use a new classWindowStageto represent the different window stages. Previously we were dealing withList<OperatorFactory>orList<List<OperatorFactory>>, and doing a bunch ofinstanceofchecks, so this refactor makes it much more readable and cleaner.This PR does not have any functional change.
This PR has: