WindowOperatorQueryFrameProcessorFactory: Pass QueryContext instead of WindowOperatorQuery to WindowOperatorQueryFrameProcessor#17405
Merged
cryptoe merged 6 commits intoapache:masterfrom Nov 7, 2024
Conversation
…ery to subsequent layers
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
Contributor
Author
|
@cryptoe As discussed offline, closing this PR as the change doesn't offer us any benefits (like performance etc), and isn't worth the backward compatibility efforts. |
Akshat-Jain
changed the title
adarshsanjeev
approved these changes
Nov 4, 2024
kgyrtkirk
approved these changes
Nov 4, 2024
| } | ||
|
|
||
| @Nullable | ||
| public static VirtualColumn makeSegmentGranularityVirtualColumn(final ObjectMapper jsonMapper, final Query<?> query) |
Member
There was a problem hiding this comment.
note: there are only 2 callsites; inline?
Contributor
Author
There was a problem hiding this comment.
Have made the change.
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
…f WindowOperatorQuery to WindowOperatorQueryFrameProcessor (apache#17405) * WindowOperatorQueryKit: Pass QueryContext instead of WindowOperatorQuery to subsequent layers * Add serializer for QueryContext class * Revert changes of WindowOperatorQueryFrameProcessorFactory json param * Fix checkstyle * Address review comment: Remove older method in favor of calling new method inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
WindowOperatorQueryKitwas passingWindowOperatorQueryto the frame processor layers. It was suggested in #17158 (comment) that we should pass only the stuff that's needed in the frame processor layer.Changing the WindowOperatorQueryFrameProcessorFactory's signature is backwards incompatible, so we are avoiding that. But we can make the change for WindowOperatorQueryFrameProcessor atleast.
Hence, this PR makes the change to pass
QueryContextinstead ofWindowOperatorQueryto WindowOperatorQueryFrameProcessor.This PR has: