Fix loading lookup extension#17212
Conversation
2ecfa47 to
d9e4cd9
Compare
|
@cryptoe @LakshSingla @kfaraz Can you guys take a quick look at this? |
d9e4cd9 to
4339c87
Compare
|
@abhishekrb19 can you please re-run the pipeline one more time? |
4339c87 to
c8772ae
Compare
|
@Akshat-Jain thanks for the review! PR updated, can you give it one more round? |
abhishekrb19
left a comment
There was a problem hiding this comment.
Some minor comments
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
c8772ae to
9e1c412
Compare
|
@Akshat-Jain @abhishekrb19 Thanks for the review. One more round please. |
There was a problem hiding this comment.
@TessaIO a final set of comments. Looks good otherwise, thanks!
Also, we don't typically force push changes to make reviewing easier. The commits will be squashed and merged as one when committing to master.
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
|
@abhishekrb19 PR updated! |
Akshat-Jain
left a comment
There was a problem hiding this comment.
Thanks for the PR and for addressing all the review comments!
Looks good to me! :)
abhishekrb19
left a comment
There was a problem hiding this comment.
Thanks for your first contribution @TessaIO, and thanks to @Akshat-Jain for the in-depth review!
@TessaIO, do you mind merging the latest master into this branch to get a clean CI run? I can commit this change after that.
…ading-lookup-extension
|
@abhishekrb19 done |
|
@abhishekrb19 in which version will the fix be included? |
|
@kfaraz is there a plan to include this fix in new releases? |
Resolves #17337.
Description
This PR aims to change the behavior of the druid lookups-cached-single extension. In fact, we aim to introduce the option to iterate over fetched data from the dataFetcher. We need this in the case of loadingLookups, that's why these changes don't impact the pollingLookup feature.
I also added the handling of a use case where the data exists in Druid but not in the actual data fetcher, which is in our use-case JDBC Data fetcher.
Release note
Key changed/added classes in this PR
Support iterating over fetched data for the loadinglookups for the druid lookups-cached-single extensionThis PR has: