docs: fix cached lookup module documentation#17527
Merged
abhishekrb19 merged 2 commits intoapache:masterfrom Dec 6, 2024
Merged
docs: fix cached lookup module documentation#17527abhishekrb19 merged 2 commits intoapache:masterfrom
abhishekrb19 merged 2 commits intoapache:masterfrom
Conversation
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
Contributor
Author
|
/cc @Akshat-Jain |
Akshat-Jain
reviewed
Dec 2, 2024
Contributor
Akshat-Jain
left a comment
There was a problem hiding this comment.
Thanks @TessaIO for getting back to this! 🙌
While the changes are technically fine, I have a couple of nits related to formatting:
- The JSON indentation seems incorrect. Can you please format the JSON like it's done in https://github.com/apache/druid/blob/master/docs/development/extensions-core/catalog.md, for example?
- Can you please add space after
:character? For example,"connectorConfig":{should be changed to"connectorConfig": {. It's a minor comment, but helps with readability.
Thanks!
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
Akshat-Jain
approved these changes
Dec 2, 2024
Contributor
Akshat-Jain
left a comment
There was a problem hiding this comment.
Thanks @TessaIO for the contribution. LGTM!
abhishekrb19
approved these changes
Dec 6, 2024
Contributor
abhishekrb19
left a comment
There was a problem hiding this comment.
thanks for the update! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17337 and #17212 (comment).
Description
Fixes Cached Lookup Module documentation
Release note
This PR has: