Skip to content

docs: fix cached lookup module documentation#17527

Merged
abhishekrb19 merged 2 commits intoapache:masterfrom
TessaIO:fix-loading-lookup-documentation
Dec 6, 2024
Merged

docs: fix cached lookup module documentation#17527
abhishekrb19 merged 2 commits intoapache:masterfrom
TessaIO:fix-loading-lookup-documentation

Conversation

@TessaIO
Copy link
Copy Markdown
Contributor

@TessaIO TessaIO commented Dec 2, 2024

Fixes #17337 and #17212 (comment).

Description

Fixes Cached Lookup Module documentation

Release note

This PR Fixes Cached Lookup Module documentation

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
@TessaIO
Copy link
Copy Markdown
Contributor Author

TessaIO commented Dec 2, 2024

/cc @Akshat-Jain

Copy link
Copy Markdown
Contributor

@Akshat-Jain Akshat-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TessaIO for getting back to this! 🙌

While the changes are technically fine, I have a couple of nits related to formatting:

  1. The JSON indentation seems incorrect. Can you please format the JSON like it's done in https://github.com/apache/druid/blob/master/docs/development/extensions-core/catalog.md, for example?
  2. Can you please add space after : character? For example, "connectorConfig":{ should be changed to "connectorConfig": {. It's a minor comment, but helps with readability.

Thanks!

Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
@TessaIO TessaIO requested a review from Akshat-Jain December 2, 2024 10:52
Copy link
Copy Markdown
Contributor

@Akshat-Jain Akshat-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TessaIO for the contribution. LGTM!

Copy link
Copy Markdown
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update! 👍

@abhishekrb19 abhishekrb19 merged commit 93c123a into apache:master Dec 6, 2024
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Druid loading lookups failed to iterate over fetched data

4 participants