Skip generating task context reports for sub tasks#17219
Merged
georgew5656 merged 2 commits intoapache:masterfrom Oct 2, 2024
Merged
Skip generating task context reports for sub tasks#17219georgew5656 merged 2 commits intoapache:masterfrom
georgew5656 merged 2 commits intoapache:masterfrom
Conversation
kfaraz
reviewed
Oct 2, 2024
kfaraz
approved these changes
Oct 2, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
thanks for the fix, @arunramani !
Contributor
|
It looks like the issue where native ingestion tasks fail during rolling updates was introduced in #16041 which is in Druid 30. @arunramani @kfaraz I've updated the Release note in the description to mention that version as I don't see a connection with this change and Druid 24. Let me know if that is incorrect |
Contributor
|
Thanks, @suneet-s ! |
arunramani
added a commit
to arunramani/druid
that referenced
this pull request
Oct 2, 2024
* Skip task context for sub tasks * DRY a little + skip context for live report
arunramani
added a commit
to arunramani/druid
that referenced
this pull request
Oct 2, 2024
* Skip task context for sub tasks * DRY a little + skip context for live report
10 tasks
kfaraz
pushed a commit
that referenced
this pull request
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TaskContextReports generated by subtasks are not utilized by the parent task or preserved in any way. This change removes the inclusion of the task context for child tasks. This also fixes an issue with rolling upgrades from the version beforeTaskContextReportexisted to after.Release note
Fix native ingestion task failures during rolling upgrades from a version before Druid 30 to a later version.
Key changed/added classes in this PR
AbstractBatchIndexTaskPartialSegmentGenerateTaskSinglePhaseSubTaskThis PR has: