Skip to content

[Backport] Skip generating task context reports for sub tasks (#17219)#17223

Merged
kfaraz merged 1 commit intoapache:31.0.0from
arunramani:backport-fix
Oct 3, 2024
Merged

[Backport] Skip generating task context reports for sub tasks (#17219)#17223
kfaraz merged 1 commit intoapache:31.0.0from
arunramani:backport-fix

Conversation

@arunramani
Copy link
Copy Markdown
Contributor

Description

TaskContextReports generated by subtasks are not utilized by the parent task or preserved in any way. This change removes the inclusion of the task context for child tasks. This also fixes an issue with rolling upgrades from the version before TaskContextReport existed to after.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

* Skip task context for sub tasks

* DRY a little + skip context for live report
@ac9817
Copy link
Copy Markdown
Contributor

ac9817 commented Oct 2, 2024

clean cherry-pick #17219

ac9817

This comment was marked as off-topic.

@abhishekrb19 abhishekrb19 added this to the 31.0.0 milestone Oct 2, 2024
@kfaraz kfaraz merged commit 13a52de into apache:31.0.0 Oct 3, 2024
@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Oct 3, 2024

Thanks for the backport, @arunramani !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants