Removed Microsecond from Extract function#17247
Merged
kgyrtkirk merged 1 commit intoapache:masterfrom Oct 11, 2024
Merged
Conversation
Contributor
Author
|
@kgyrtkirk Can you please help to review this. I came across this while exploring Druid. I also want to know if there is a reason to still use joda-time ? It is generally recommended to migrate to java time since Java8. If you want I can look at the feasibility of migrating from joda-time to java time. |
kgyrtkirk
reviewed
Oct 7, 2024
| testQuery( | ||
| "SELECT COUNT(*) FROM druid.foo4\n" | ||
| + "WHERE EXTRACT(YEAR FROM __time) = 2000\n" | ||
| + "AND EXTRACT(MICROSECOND FROM __time) = 946723\n" |
Member
There was a problem hiding this comment.
🤦 it was clearly wrong; 695 ms and 946723 microsec...
Member
|
we could possibly migrate to |
kgyrtkirk
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
epoch(in secs)/1000which is incorrect.This change was added as part of ea4bad7
Bug
NOTE: Currently joda-time only supports millisecond precision. As of java8 release it a general recommendation to move from joda-time to new date and time API found in the java.time package.