MSQ WF: Pass a flag from broker to determine operator chain transformation#17443
Merged
cryptoe merged 7 commits intoapache:masterfrom Nov 12, 2024
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
cryptoe
approved these changes
Nov 7, 2024
…owOperatorQueryKit with query context
cryptoe
reviewed
Nov 11, 2024
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jan 13, 2026
PR apache#18875 caused a regression in WindowOperatorQuery planning, by causing non-outermost WindowOperatorQuery to be planned without windowFunctionOperatorTransformation (see apache#17443). This happened because only the outermost query has the windowFunctionOperatorTransformation parameter. This patch fixes the problem by propagating the context parameter from the outermost queries to any inner WindowOperatorQuery instances.
gianm
added a commit
that referenced
this pull request
Jan 13, 2026
PR #18875 caused a regression in WindowOperatorQuery planning, by causing non-outermost WindowOperatorQuery to be planned without windowFunctionOperatorTransformation (see #17443). This happened because only the outermost query has the windowFunctionOperatorTransformation parameter. This patch fixes the problem by propagating the context parameter from the outermost queries to any inner WindowOperatorQuery instances.
kgyrtkirk
pushed a commit
that referenced
this pull request
Jan 20, 2026
PR #18875 caused a regression in WindowOperatorQuery planning, by causing non-outermost WindowOperatorQuery to be planned without windowFunctionOperatorTransformation (see #17443). This happened because only the outermost query has the windowFunctionOperatorTransformation parameter. This patch fixes the problem by propagating the context parameter from the outermost queries to any inner WindowOperatorQuery instances. (cherry picked from commit 07de2ff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #17433, we had to move the operator-chain-transformation logic to the MSQ worker layer to ensure backward compatibility. But it wasn't ideal since such logic shouldn't be a responsibility of the worker.
On further offline discussion, an alternative was suggested that we can pass a flag from the broker during query execution.
If MSQ controller sees the flag, then it does the operator transformation. Otherwise it doesn't do the operator transformation.
This relies on the upgrade order of the different services. This allows us to achieve backward compatibility since brokers are upgraded after indexers/middlemanagers, so passing a flag is essentially passing info whether all indexers/middlemanagers have been upgraded or not - hence helps us achieve backward compatibility.
This PR has: