Skip to content

MSQ: Fix WindowOperatorQuery planning.#18911

Merged
gianm merged 1 commit intoapache:masterfrom
gianm:msq-restore-wot
Jan 13, 2026
Merged

MSQ: Fix WindowOperatorQuery planning.#18911
gianm merged 1 commit intoapache:masterfrom
gianm:msq-restore-wot

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Jan 13, 2026

PR #18875 caused a regression in WindowOperatorQuery planning, by causing non-outermost WindowOperatorQuery to be planned without windowFunctionOperatorTransformation (see #17443). This happened because only the outermost query has the windowFunctionOperatorTransformation parameter.

This patch fixes the problem by propagating the context parameter from the outermost queries to any inner WindowOperatorQuery instances.

PR apache#18875 caused a regression in WindowOperatorQuery planning, by
causing non-outermost WindowOperatorQuery to be planned without
windowFunctionOperatorTransformation (see apache#17443). This happened because
only the outermost query has the windowFunctionOperatorTransformation
parameter.

This patch fixes the problem by propagating the context parameter from
the outermost queries to any inner WindowOperatorQuery instances.
@gianm gianm added this to the 36.0.0 milestone Jan 13, 2026
@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Jan 13, 2026
@gianm gianm added the Bug label Jan 13, 2026
@kgyrtkirk kgyrtkirk closed this Jan 13, 2026
@kgyrtkirk kgyrtkirk reopened this Jan 13, 2026
@kgyrtkirk
Copy link
Copy Markdown
Member

close/open to get the flaky fix from master

@gianm gianm merged commit 07de2ff into apache:master Jan 13, 2026
79 of 80 checks passed
@gianm gianm deleted the msq-restore-wot branch January 13, 2026 21:53
kgyrtkirk pushed a commit that referenced this pull request Jan 20, 2026
PR #18875 caused a regression in WindowOperatorQuery planning, by
causing non-outermost WindowOperatorQuery to be planned without
windowFunctionOperatorTransformation (see #17443). This happened because
only the outermost query has the windowFunctionOperatorTransformation
parameter.

This patch fixes the problem by propagating the context parameter from
the outermost queries to any inner WindowOperatorQuery instances.

(cherry picked from commit 07de2ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants