Do not emit metrics from integration testing client#17867
Merged
kfaraz merged 17 commits intoapache:masterfrom Apr 5, 2025
Merged
Do not emit metrics from integration testing client#17867kfaraz merged 17 commits intoapache:masterfrom
kfaraz merged 17 commits intoapache:masterfrom
Conversation
9 tasks
Contributor
Author
|
Had a successful run: https://github.com/apache/druid/actions/runs/14258874576/job/39967371072 Re-triggered the tests. |
kfaraz
changed the title
Contributor
Author
|
Failed in the latest run due to some discrepancy in the compaction config. |
Contributor
Author
|
Idenfied the source of flakiness and created PR #17877 |
Akshat-Jain
reviewed
Apr 4, 2025
capistrant
approved these changes
Apr 4, 2025
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
I'm all for less verbose output 💯
Contributor
Author
|
Thanks for the reviews, @Akshat-Jain , @capistrant ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standard ITs are full of messages like:
These messages never provide any useful info. Other than these, no other metrics are emitted
from the integration testing client. So we can just disable the metric emission for now.
Changes
ZookeeperClientNoopEmitteron the client side of standard ITs/compaction/statusAPI intoAutoCompactionSnapshot