Fix flakiness in compaction ITs#17877
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 4, 2025
Merged
Conversation
cryptoe
approved these changes
Apr 4, 2025
Contributor
|
While the Patch fixes the flakiness there is still a race in task slots update logic rite ? As in if we set the compaction config task slots via the overlord API, the coordinator API can override it no ? |
10 tasks
cryptoe
pushed a commit
to cryptoe/druid
that referenced
this pull request
Apr 4, 2025
(cherry picked from commit 11c2ad1)
Contributor
Author
|
Thanks for the review, @cryptoe ! |
Contributor
Author
Yes, but that is no different from the race condition between two users hitting the same API. |
kgyrtkirk
pushed a commit
that referenced
this pull request
Apr 5, 2025
(cherry picked from commit 11c2ad1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#17834 has made some ITs flaky due to a race condition in the
/taskslotsCoordinator API.Since the Overlord now exposes APIs to update compaction configs, the Coordinator may have
a stale version of the config while trying to update the task slots. This config is refreshed from
the metadata store every minute. But if the config has just been updated on the Overlord and
the taskslots API is called, it may end up reverting the change performed by the Overlord API.
This issue does not exist with the other compaction config APIs.
Changes
/taskslotsAPIThis PR has: