k8s: Update fabric8 to 6.13.1, switch to Vert.x http client.#17913
Merged
gianm merged 7 commits intoapache:masterfrom Apr 16, 2025
Merged
k8s: Update fabric8 to 6.13.1, switch to Vert.x http client.#17913gianm merged 7 commits intoapache:masterfrom
gianm merged 7 commits intoapache:masterfrom
Conversation
fabric8 6.x uses the OkHttp client by default, which itself uses an unbounded-size cached pool, with 60s timeout, for making requests. In production with large task counts, this leads to lots of thread churn. The Vert.x client is the default in fabric8 7.x, and is better behaved. By default it uses a worker pool of 20 threads (see javadoc for VertxOptions). This patch uses fabric8 6.13.1 rather than some later version, because higher versions are not compatible with Jackson 2.12.
clintropolis
approved these changes
Apr 15, 2025
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
Did some reading about the http client options too and agree that this change seems reasonable and that this should probably behave a bit nicer behavior in larger clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fabric8 6.x uses the OkHttp client by default, which itself uses an unbounded-size cached pool, with 60s timeout, for making requests. In production with large task counts, this leads to lots of thread churn.
The Vert.x client is the default in fabric8 7.x, and is better behaved. By default it uses a worker pool of 20 threads (see javadoc for VertxOptions).
This patch uses fabric8 6.13.1 rather than some later version, because higher versions are not compatible with Jackson 2.12.
Btw: I initially tried using the Jetty http client, since fabric8 does support that now. However, I ran into linking problems because fabric8 is written against Jetty 12 and we use Jetty 9. Some classes it needed were missing. So I ended up going with Vert.x instead. The implementation in fabric8 is probably better tested, anyway, since Vert.x is the default now in fabric8 7.x.