Bump jackson to 2.18.4 and fabric8 to 7.2.0#18013
Conversation
|
I'm trying to figure out why jacoco says I don't have line coverage on the first of the 2 changed lines in JodaStuff... the debugger definitely hits it when I set a break. Found this chatting with copilot.
|
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
awesome! thank you!
might worth to ban jaxb-api under bannedDependencies in the root pom.xml
note: I think the exclusions could be done via dependencyManagement ; but since with import exclusions doesn't work - that will require to re-declare these 2 in the root pom...not much cleaner....
…transitive dependency
|
Thanks for the review @kgyrtkirk! I am trying out the explicit ban in root pom |
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
|
I'm currently running the IndexHadoop ITs locally since those are disabled in CI. I want to ensure we are not breaking hadoop integrations by upgrading jackson |
Confirmed that index_hadoop is able to run with jackson 2.18.4 through these local index_hadoop tasks against hadoop 3.3.6 |
|
I've noticed that some artifacts by chance that for example would you like to do any more things before merging this? what would it take to run the |
CI for hadoop used to be turned on (at least I think I remember that it was), so I assume all it would take is some conditional set on a label existing to run or not. I think the result of the dev list discussion on future of java11 and hadoop support plays into how worthwhile it would be to try and add back. Short of baking it in a cluster that is more real than our ITs or my local docker cluster, I don't know of any other things that would be worth doing before this goes in |
|
thank you @capistrant for upgrading these! :) |
| <dependency> | ||
| <groupId>com.fasterxml.jackson.jaxrs</groupId> | ||
| <artifactId>jackson-jaxrs-json-provider</artifactId> | ||
| <exclusions> |
There was a problem hiding this comment.
Is there a reason we did not push the exclusion to the main pom.
cc @capistrant @kgyrtkirk ?
There was a problem hiding this comment.
I believe it was lost in the cracks..should have been better to do that - but I wanted to get it in since it was open for a month; and it was really usefull for my other dep update PR
there is also some note about snakeyaml being set to 1.33; maybe that could also be taken care of together
There was a problem hiding this comment.
My bad on this. Let me try to address ASAP.
…x IGNORE_DUPLICATE_MODULE_REGISTRATIONS. Disabling this feature in case multiple modules are registered with the same name.
…RE_DUPLICATE_MODULE_REGISTRATIONS. Disabling this feature in case multiple modules are registered with the same name. (#18167)
(cherry picked from commit 691ea3c)
* Bump jackson to 2.14.1 and fabric8 to 7.2.0 (apache#18013) (cherry picked from commit 691ea3c) * Fix typo * Removal of quidem-ut --------- Co-authored-by: Lucas Capistrant <capistrant@users.noreply.github.com>
* Bump jackson to 2.14.1 and fabric8 to 7.2.0 (apache#18013) (cherry picked from commit 691ea3c) * Fix typo * Removal of quidem-ut --------- Co-authored-by: Lucas Capistrant <capistrant@users.noreply.github.com> (cherry picked from commit 4ce81c1)
(cherry picked from commit 691ea3c)
(cherry picked from commit 691ea3c)
3 participants
Description
Getting to Fabric8 7.x requires jackson to be updated (ref #17913). I targeted jackson 2.18.x since jackson 2.19 is brand new. Fabric 8 7.3.0 (also brand new) depends on jackson 2.19, so I stuck with 7.2. Surprisingly ran into only a single compile issue related to bumping jackson.
The jaxb excludes are added because #17370 replaced javax bind with jakarta bind and not excluding it leads to our static checks getting cranky about used undefined deps and unused defined deps. As I understand it, both packages still use the
javaxpackage naming and only differ in maven coordinates as a part of the efforts to smooth javax --> jakarta migration.Testing
Release note
Key changed/added classes in this PR
JodaStuffThis PR has: