Web console: defensive coding around dayjs#18723
Merged
vogievetsky merged 1 commit intoapache:masterfrom Nov 6, 2025
Merged
Conversation
clintropolis
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty fix for a bug that is affecting me right now.
Segment view crashes if there are segments with 5 digit year start/end dates (far future data).
This bug was introduced in #18455. basically
dayjs(value).toISOString()will throw ifvalueis an unparsable date like (12025-11-06T20:43:44.172Z). So it needs to be wrapped in a try catch or some other check. In the task view this was coded more defensively:But in the segments view this will throw.
I made a quick and dirty fix that I verified works.
I am not utilizing
day.isValid()in my fix because I believe there might be a way to achieve the functionality desired in #18455 without importing dayjs at all which would save an import. Will look into it after I can access the segment view in my cluster.Also I want to look into wrapping the table of every view in a React error boundary