Skip to content

Web console: defensive coding around dayjs #18723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 1 commit into from
Nov 6, 2025
Merged

Web console: defensive coding around dayjs #18723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web-console/src/utils/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,9 @@ export function formatDate(value: string) {
LocalStorageKeys.WEB_CONSOLE_CONFIGS,
);
const showLocalTime = webConsoleConfig?.showLocalTime;
return showLocalTime ? dayjs(value).format(DATE_FORMAT) : dayjs(value).toISOString();
try {
return showLocalTime ? dayjs(value).format(DATE_FORMAT) : dayjs(value).toISOString();
} catch {
return value;
}
}
25 changes: 17 additions & 8 deletions web-console/src/views/segments-view/segments-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,16 @@ function segmentFiltersToExpression(filters: Filter[]): SqlExpression {
if (modeAndNeedle.mode === '~') {
return sqlQueryCustomTableFilter(filter);
}
const internalFilter = { ...filter };
const formattedDate = formatDate(modeAndNeedle.needle);
const filterDate = dayjs(formattedDate).toISOString();
filter.value = combineModeAndNeedle(modeAndNeedle.mode, formattedDate);
internalFilter.value = combineModeAndNeedle(modeAndNeedle.mode, filterDate);
return sqlQueryCustomTableFilter(internalFilter);
try {
const internalFilter = { ...filter };
const formattedDate = formatDate(modeAndNeedle.needle);
const filterDate = dayjs(formattedDate).toISOString();
filter.value = combineModeAndNeedle(modeAndNeedle.mode, formattedDate);
internalFilter.value = combineModeAndNeedle(modeAndNeedle.mode, filterDate);
return sqlQueryCustomTableFilter(internalFilter);
} catch {
return sqlQueryCustomTableFilter(filter);
}
}
if (filter.id === 'shard_type') {
// Special handling for shard_type that needs to be searched for in the shard_spec
Expand Down Expand Up @@ -743,8 +747,13 @@ export class SegmentsView extends React.PureComponent<SegmentsViewProps, Segment
show: visibleColumns.shown('Time span'),
id: 'time_span',
className: 'padded',
accessor: ({ start, end }) =>
computeSegmentTimeSpan(dayjs(start).toISOString(), dayjs(end).toISOString()),
accessor: ({ start, end }) => {
try {
return computeSegmentTimeSpan(dayjs(start).toISOString(), dayjs(end).toISOString());
} catch {
return 'Invalid start or end';
}
},
width: 100,
sortable: false,
filterable: false,
Expand Down