adding Upper/Lower Bound Filter by b-slim · Pull Request #1936 · apache/druid

b-slim · 2015-11-08T18:55:27Z

This Pr is Fix to #1879

himanshug · 2015-11-09T04:56:18Z

this is probably going to have very weird results for the age use case e.g. this will say that age "100" is smaller than age "20" . I believe, you would need to at least support a flag saying whether the comparison should be done by converting string to numbers.

@himanshug thanks, done

drcrallen · 2015-11-09T17:28:32Z

@himanshug / @b-slim how would you feel if the numeric condition just used the comparator from io.druid.query.topn.AlphaNumericTopNMetricSpec ?

drcrallen · 2015-11-09T17:29:51Z

and possibly make it "alphaNumeric" instead of just numeric?

himanshug · 2015-11-09T18:29:40Z

@drcrallen @b-slim SGTM

b-slim · 2015-11-09T19:31:11Z

@drcrallen thanks, please check it out

drcrallen · 2015-11-10T01:30:57Z

Is it possible to test each of the return cases for isAlphaNumeric both true and false?

@drcrallen done !

drcrallen · 2015-11-10T17:38:46Z

Is it possible to test the apply for the 8 cases?

xvrl · 2015-11-10T17:38:54Z

@b-slim would it make sense to add less than and greater than filters as well while we're at it?
Between could be expressed as a combination of those or have it's own implementation, depending on whether it's worth to optimize, but it seems a bit strange to have between but not < <= > >=

b-slim · 2015-11-11T14:01:03Z

@xvrl i see how this can be useful, but i think we can have between, < <= > and >= all together.
i do prefer to have between since it saves the amount of bytes sent and and deserialized.
so i guess we can start with this, then i will send another PR of the rest of the troops.

himanshug · 2015-11-11T16:47:19Z

@xvrl did you mean adding more filters or updating the api for same filter?
@b-slim @xvrl can we handle all cases by calling it a "bound" filter and based on whether user specified one or both of "lower" and "upper", the filter should be able to do appropriate thing.
so if user specifies
"lower" only : then it becomes a lower bound filter
"upper" only: then it becomes a upper bound filter
"lower" and "upper" both: then it becomes between filter

drcrallen · 2015-11-16T18:06:20Z

b-slim · 2015-11-21T21:41:28Z

@himanshug and @xvrl please checkout this.

himanshug · 2015-11-25T03:47:14Z

"...by comparing dimension..."

himanshug · 2015-11-25T04:13:35Z

b-slim · 2015-12-08T19:12:01Z

@himanshug can u please check this

fjy · 2015-12-08T23:21:22Z

@b-slim Merge conflicts
@himanshug any more comments?

himanshug · 2015-12-09T22:29:52Z

I think another PR introduced a separate variable for 0xFF in this context, can you use that?

himanshug · 2015-12-09T22:30:38Z

👍 after #1936 (comment) is resolved, pls squash your commits.

b-slim · 2015-12-10T14:48:35Z

@himanshug done

himanshug · 2015-12-10T23:23:24Z

👍 for me

b-slim · 2015-12-15T03:00:02Z

@fjy this is ready to go can you merge it please

fjy · 2015-12-29T18:11:19Z

I read this over again, and I think it is cool. 👍

adding Upper/Lower Bound Filter

…ot be regarded as parsing fail

himanshug reviewed Nov 9, 2015
View reviewed changes

drcrallen reviewed Nov 10, 2015
View reviewed changes

drcrallen mentioned this pull request Nov 16, 2015

fixed #1879: Add support for range filter #1972

Closed

drcrallen reviewed Nov 16, 2015
View reviewed changes

b-slim force-pushed the between_range_with_predicat branch from 1ea49e3 to 82ad49f Compare November 21, 2015 21:32

himanshug changed the title ~~adding Between Filter~~ adding Upper/Lower Bound Filter Nov 25, 2015

himanshug reviewed Nov 25, 2015
View reviewed changes

Comment thread processing/src/test/java/io/druid/query/filter/BetweenDimFilterTests.java Outdated

Copy link
Copy Markdown

Contributor

himanshug Nov 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bound

b-slim force-pushed the between_range_with_predicat branch from a6b4d14 to db6366c Compare December 8, 2015 15:36

himanshug reviewed Dec 9, 2015
View reviewed changes

b-slim force-pushed the between_range_with_predicat branch from db6366c to 3253a10 Compare December 10, 2015 14:45

adding Bound Filter

77afdf2

b-slim force-pushed the between_range_with_predicat branch from 3253a10 to 77afdf2 Compare December 10, 2015 14:47

b-slim closed this Dec 10, 2015

b-slim reopened this Dec 10, 2015

b-slim closed this Dec 10, 2015

b-slim reopened this Dec 10, 2015

fjy added a commit that referenced this pull request Dec 29, 2015

Merge pull request #1936 from b-slim/between_range_with_predicat

e14ad74

adding Upper/Lower Bound Filter

fjy merged commit e14ad74 into apache:master Dec 29, 2015

fjy mentioned this pull request Jan 26, 2016

Add a range filter option (for numeric dimensions and strings) #1879

Closed

fjy modified the milestone: 0.9.0 Feb 4, 2016

fjy mentioned this pull request Feb 5, 2016

druid-0.9.0 release notes #2404

Closed

seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020

apache#1936 Exception thrown in processing row in index task should n…

e146f91

…ot be regarded as parsing fail

Conversation

b-slim commented Nov 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drcrallen commented Nov 9, 2015

Uh oh!

drcrallen commented Nov 9, 2015

Uh oh!

himanshug commented Nov 9, 2015

Uh oh!

b-slim commented Nov 9, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drcrallen commented Nov 10, 2015

Uh oh!

xvrl commented Nov 10, 2015

Uh oh!

b-slim commented Nov 11, 2015

Uh oh!

himanshug commented Nov 11, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

b-slim commented Nov 21, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

b-slim commented Dec 8, 2015

Uh oh!

fjy commented Dec 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

himanshug commented Dec 9, 2015

Uh oh!

b-slim commented Dec 10, 2015

Uh oh!

himanshug commented Dec 10, 2015

Uh oh!

b-slim commented Dec 15, 2015

Uh oh!

fjy commented Dec 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants