fixed #1879: Add support for range filter#1972
Closed
zhxiaogg wants to merge 1 commit intoapache:masterfrom
zhxiaogg:feature/between_filter
Closed
fixed #1879: Add support for range filter#1972zhxiaogg wants to merge 1 commit intoapache:masterfrom zhxiaogg:feature/between_filter
zhxiaogg wants to merge 1 commit intoapache:masterfrom
zhxiaogg:feature/between_filter
Conversation
Contributor
|
Most boundaries in druid are "greater than or equal" on the lower and "less than" on the upper. Can you give some examples of if that would or would not work for this? |
Contributor
There was a problem hiding this comment.
can be boolean in which case it will default to false
Contributor
Contributor
Author
|
@drcrallen yes, i just noticed that... oops! |
Contributor
Author
|
@drcrallen can you still review this code? I'll pick a new issue later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it supports the following schema:
The
numericallyfield can be omitted and defaults to be false if bothupperandlowerare not numbers. It means the omitted field will be true if given:and will be false if given:
Also worth note:
value <= upper && value >= lowerand does NOT support configurationFinally, I just finished coding and have NOT tested the code. Hopefully somebody could help to review this code and feed me back some suggestions.